Rustfmt librustc resolve

[little-dude]

Another rustfmt PR.
I ran rustfmt, then split the changes in multiple commits. First commit are the non-problematic changed. The others are all the little weirdness that caught my attention and could be discussed.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[little-dude]

r? @nrc

[nrc]

re the 9th commit - when the function decl needs multiple lines we always split the args, I think this is fine - once a function decl gets this long the readability benefits of argument per line outweigh the benefits of keeping things on a few lines.

[nrc]

ping @little-dude Can you rebase this branch please? Did you need any more help with the comments?

[little-dude]

@nrc sorry, it's just lack of time (getting married in a few days :D). I'll try to do this later today.

[little-dude]

seems like github removed all you comments after I rebased... In one of them you were asking about the version of rustfmt I'm using:

commit 3ce2b840cf73253cedf86aaf3b6b7a71e27d6b79
Merge: 58ff0d8 be77f8a
Author: Marcus Klaas de Vries <mail@marcusklaas.nl>
Date: Sat Oct 24 16:38:51 2015 +0200
Merge pull request #522 from marcusklaas/writing-tests
Add a brief overview of rustfmt tests

[nrc]

@little-dude no worries - not trying to rush you, just checking you didn't need anything from me. And congrats!

[nrc]

lib.rs:2484 - comments are misaligned

I think that is the only thing that needs fixing up now.

[little-dude]

lib.rs:2484 - comments are misaligned

thanks, I'll fix this.

And congrats!

thank you!

[bors]

☔ The latest upstream changes (presumably #29547) made this pull request unmergeable. Please resolve the merge conflicts.

[little-dude]

@nrc I rebased against master and fixed the indentation of the comments that were misaligned. See last two commits.

If this is good for you I'll squash everything.

[nrc]

@little-dude looks goo, thanks! r+ with a squash

[bors]

☔ The latest upstream changes (presumably #29778) made this pull request unmergeable. Please resolve the merge conflicts.

[little-dude]

Arf. I'll rebase again.

[little-dude]

@nrc: I rebased, could you review again please?

[nrc]

@bors: r+

[bors]

📌 Commit 889b0e9 has been approved by nrc

[bors]

⌛ Testing commit 889b0e9 with merge b7845f9...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt