Let str::replace take a pattern by wthrowe · Pull Request #29498 · rust-lang/rust

wthrowe · 2015-11-01T04:56:14Z

It appears this was left out of RFC rust-lang/rfcs#528 because it might be useful to
also generalize the second argument in some way. That doesn't seem to
prevent generalizing the first argument now, however.

This is a [breaking-change] because it could cause type-inference to
fail where it previously succeeded.

Also update docs for a few other methods that still referred to &str instead of patterns.

rust-highfive · 2015-11-01T04:56:26Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

nagisa · 2015-11-01T13:35:31Z

Cause of travis failure. Rust can’t auto-deref this array into closure because there’s nothing that explicitly requests a slice.

wthrowe · 2015-11-01T19:49:37Z

Sorry about that. Probably fixed now. (I can't run tests locally at the moment because of #29492.)

bluss · 2015-11-01T21:47:16Z

With #26870 (Default Type Parameter Fallback) enabled by default, this could avoid being breaking. Not sure if it's worth it to wait.

Maybe there's a case where it's breaking anyway, but basically type param fallback “opens the floodgates” to generalizing API.

alexcrichton · 2015-11-02T19:06:34Z

This seems good to me, although I would like to have a crater run ahead of time with this to ensure we don't have much unintended breakage. If we have to wait for #26870 to get turned on by default that's also probably not the end of the world!

wthrowe · 2015-11-02T20:16:09Z

I'm fine with waiting for default type parameter fallback if you prefer. If you decide to wait I'll split the doc fixes into a separate pull request

bors · 2015-12-01T05:58:45Z

☔ The latest upstream changes (presumably #30057) made this pull request unmergeable. Please resolve the merge conflicts.

It appears this was left out of RFC rust-lang#528 because it might be useful to also generalize the second argument in some way. That doesn't seem to prevent generalizing the first argument now, however. This is a [breaking-change] because it could cause type-inference to fail where it previously succeeded.

wthrowe · 2015-12-08T03:31:50Z

Rebased.

alexcrichton · 2015-12-08T20:27:11Z

A crater report reports 4 regressions, but I think they're all spurious and unrelated to this change.

I was thinking about this though and the "most generalized" form of the API here would perhaps be to have the replacement either be &str or perhaps Fn(&str) -> String (or something like that) where you can use the string (which with patterns you don't know quite what matched) to generate the replacement (rather than always have the same replacement).

In some sense though this is getting pretty close to just an API around regexes, however, so we may not want to go too far down that route. Regardless I'm gonna tag this with T-libs so we can talk about it in the libs triage meeting.

bluss · 2015-12-20T09:50:19Z

Ok, default type parameter fallback seems to not be likely to arrive any time soon (unfortunately), so we should continue?

aturon · 2016-01-08T20:11:53Z

We discussed this in the libs team meeting this week, and are happy to go forward, pending an additional crater run.

alexcrichton · 2016-01-12T20:18:21Z

Crater reports one regression which is just spurious, so I think this is good to go.

alexcrichton · 2016-01-12T20:18:37Z

@bors: r+ 34fe201

bors · 2016-01-12T21:15:13Z

⌛ Testing commit 34fe201 with merge 6fe73d4...

bors · 2016-01-12T22:49:00Z

💔 Test failed - auto-linux-64-opt

alexcrichton · 2016-01-12T22:50:06Z

@bors: retry

On Tue, Jan 12, 2016 at 2:49 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-linux-64-opt
http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/7639
—
Reply to this email directly or view it on GitHub
#29498 (comment).

bors · 2016-01-13T00:39:29Z

⌛ Testing commit 34fe201 with merge f40932c...

bors · 2016-01-13T02:05:02Z

💔 Test failed - auto-mac-32-opt

alexcrichton · 2016-01-13T04:21:29Z

@bors: retry

On Tuesday, January 12, 2016, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-mac-32-opt
http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/7693
—
Reply to this email directly or view it on GitHub
#29498 (comment).

bors · 2016-01-13T08:15:46Z

⌛ Testing commit 34fe201 with merge 8796e01...

It appears this was left out of RFC rust-lang/rfcs#528 because it might be useful to also generalize the second argument in some way. That doesn't seem to prevent generalizing the first argument now, however. This is a [breaking-change] because it could cause type-inference to fail where it previously succeeded. Also update docs for a few other methods that still referred to `&str` instead of patterns.

bors · 2016-01-13T12:22:50Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

rust-highfive assigned nikomatsakis Nov 1, 2015

nagisa reviewed Nov 1, 2015
View reviewed changes

wthrowe force-pushed the replace-pattern branch from a96dfdc to 6211213Compare November 1, 2015 19:48

alexcrichton assigned alexcrichton and unassigned nikomatsakis Nov 2, 2015

alexcrichton added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Nov 2, 2015

wthrowe added 2 commits December 7, 2015 22:08

Fix some str docs to refer to patterns
34fe201

wthrowe force-pushed the replace-pattern branch from 6211213 to 34fe201Compare December 8, 2015 03:31

alexcrichton added the T-libs-api [DEPRECATED; DO NOT USE] label Dec 8, 2015

Gankra removed the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Jan 6, 2016

brson added the relnotes Marks issues that should be documented in the release notes of the next release. label Jan 6, 2016

Gankra added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Jan 9, 2016

alexcrichton removed the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Jan 12, 2016

bors merged commit 34fe201 into rust-lang:masterJan 13, 2016

Uh oh!

Uh oh!

Conversation

wthrowe commented Nov 1, 2015

Uh oh!

rust-highfive commented Nov 1, 2015

Uh oh!

nagisaNov 1, 2015

Choose a reason for hiding this comment

Uh oh!

wthrowe commented Nov 1, 2015

Uh oh!

bluss commented Nov 1, 2015

Uh oh!

alexcrichton commented Nov 2, 2015

Uh oh!

wthrowe commented Nov 2, 2015

Uh oh!

bors commented Dec 1, 2015

Uh oh!

wthrowe commented Dec 8, 2015

Uh oh!

alexcrichton commented Dec 8, 2015

Uh oh!

bluss commented Dec 20, 2015

Uh oh!

aturon commented Jan 8, 2016

Uh oh!

alexcrichton commented Jan 12, 2016

Uh oh!

alexcrichton commented Jan 12, 2016

Uh oh!

bors commented Jan 12, 2016

Uh oh!

bors commented Jan 12, 2016

Uh oh!

alexcrichton commented Jan 12, 2016

Uh oh!

bors commented Jan 13, 2016

Uh oh!

bors commented Jan 13, 2016

Uh oh!

alexcrichton commented Jan 13, 2016

Uh oh!

bors commented Jan 13, 2016

Uh oh!

bors commented Jan 13, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants