Uh oh!
There was an error while loading. Please reload this page.
remove Tt prefix from TokenType variants - #29582
Conversation
rust-highfive
commented
Nov 4, 2015
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
sfackler
commented
Nov 4, 2015
Can you add |
oli-obk
commented
Nov 5, 2015
done |
sfackler
commented
Nov 5, 2015
@bors r+ |
bors
commented
Nov 5, 2015
📌 Commit 5f97df7 has been approved by |
bors
commented
Nov 5, 2015
⌛ Testing commit 5f97df7 with merge be6028c... |
bors
commented
Nov 5, 2015
💔 Test failed - auto-mac-64-nopt-t |
sfackler
commented
Nov 5, 2015
Looks like there are some tests that need to be modified as well. |
[breaking change]
oli-obk
commented
Nov 6, 2015
sorry about that... grep now returns no results for |
sfackler
commented
Nov 6, 2015
@bors r+ |
bors
commented
Nov 6, 2015
📌 Commit fcc7067 has been approved by |
bors
commented
Nov 6, 2015
⌛ Testing commit fcc7067 with merge 475f91f... |
bors
commented
Nov 6, 2015
rust-lang/rust#29582 renamed `TtToken` to `Token`. rust-lang/rust#29285 renamed `parse_expr` to `parse_expr_panic`.
[breaking change] I'm not sure if those renames are ok. [TokenType::Tt* to TokenType::*](#29582) was obvious, but for all those Item-enums it's less obvious to me what the right way forward is due to the underscore.
[breaking change] I'm not sure if those renames are ok. [TokenType::Tt* to TokenType::*](rust-lang/rust#29582) was obvious, but for all those Item-enums it's less obvious to me what the right way forward is due to the underscore.
No description provided.