Skip to content

Goyox86/rustfmting librustc front II - #29647

Merged
bors merged 1 commit into
rust-lang:masterfrom
goyox86:goyox86/rustfmting-librustc_frontII
Nov 10, 2015
Merged

Goyox86/rustfmting librustc front II#29647
bors merged 1 commit into
rust-lang:masterfrom
goyox86:goyox86/rustfmting-librustc_frontII

Conversation

@goyox86

@goyox86goyox86 commented Nov 5, 2015

Copy link
Copy Markdown
Contributor

Hi Rustaceans!

This is the second take on running latest rustfmt on librustc_front!

This is the same in #29075 but cleaned. All fixups have been applied.

//cc @nrc

@rust-highfive

rust-highfive commented Nov 5, 2015

Copy link
Copy Markdown
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@goyox86goyox86 mentioned this pull request Nov 5, 2015
Closed
@goyox86goyox86 changed the title Goyox86/rustfmting librustc front iiGoyox86/rustfmting librustc front IINov 5, 2015
@nrc

nrc commented Nov 7, 2015

Copy link
Copy Markdown
Member

r? @nrc

@rust-highfiverust-highfive assigned nrc and unassigned pnkfelixNov 7, 2015
nrc
nrc reviewed Nov 8, 2015
View reviewed changes
Comment threadsrc/librustc_front/lowering.rs Outdated

@nrcnrcNov 8, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be braced

@nrcnrcNov 8, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/nrc/rustfmt/issues/568

@nrc

nrc commented Nov 8, 2015

Copy link
Copy Markdown
Member

Thanks for re-doing this - just a couple of things I would fixup (one looks like a bug in rustfmt, but Ok to manually fix it up for now).

@goyox86

goyox86 commented Nov 8, 2015

Copy link
Copy Markdown
ContributorAuthor

Hey @nrc which are the fixups that are needed?

@nrc

nrc commented Nov 9, 2015

Copy link
Copy Markdown
Member

@goyox86 Adding braces in lowering.rs, and changing a comment to using // in hir.rs (there are comments inline).

@goyox86

goyox86 commented Nov 9, 2015

Copy link
Copy Markdown
ContributorAuthor

Fixups done @nrc

@nrc

nrc commented Nov 9, 2015

Copy link
Copy Markdown
Member

Awesome, thanks!

@bors: r+

@bors

bors commented Nov 9, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit d1b5d9c has been approved by nrc

@bors

bors commented Nov 9, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit d1b5d9c with merge f3b57a3...

@bors

bors commented Nov 9, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-mac-64-opt

@goyox86
goyox86force-pushed the goyox86/rustfmting-librustc_frontII branch from d1b5d9c to fa99261CompareNovember 9, 2015 21:55
@goyox86
goyox86force-pushed the goyox86/rustfmting-librustc_frontII branch from fa99261 to cbd2ef8CompareNovember 9, 2015 21:56
@nrc

nrc commented Nov 9, 2015

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Nov 9, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit cbd2ef8 has been approved by nrc

bors added a commit that referenced this pull request Nov 9, 2015
@bors
Auto merge of#29647- goyox86:goyox86/rustfmting-librustc_frontII, r…
205406c
…=nrc
Hi Rustaceans!
This is the second take on running latest rustfmt on librustc_front!
This is the same in #29075 but cleaned. All fixups have been applied.
//cc @nrc
@bors

bors commented Nov 9, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit cbd2ef8 with merge 205406c...

@alexcrichton

alexcrichton commented Nov 10, 2015

Copy link
Copy Markdown
Member

@bors: retry force

On Monday, November 9, 2015, bors notifications@github.com wrote:

[image: ⌛] Testing commit cbd2ef8
cbd2ef8
with merge 205406c
205406c
...

—
Reply to this email directly or view it on GitHub
#29647 (comment).

@bors

bors commented Nov 10, 2015

Copy link
Copy Markdown
Collaborator

⚡ Previous build results for auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt...

@alexcrichton

alexcrichton commented Nov 10, 2015

Copy link
Copy Markdown
Member

@bors: retry force

@bors

bors commented Nov 10, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit cbd2ef8 with merge 4b23a09...

bors added a commit that referenced this pull request Nov 10, 2015
@bors
Auto merge of#29647- goyox86:goyox86/rustfmting-librustc_frontII, r…
4b23a09
…=nrc
Hi Rustaceans!
This is the second take on running latest rustfmt on librustc_front!
This is the same in #29075 but cleaned. All fixups have been applied.
//cc @nrc
@bors

bors commented Nov 10, 2015

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors
bors merged commit cbd2ef8 into rust-lang:masterNov 10, 2015
@borsbors mentioned this pull request Nov 10, 2015
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nrcnrc

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@goyox86@rust-highfive@nrc@bors@alexcrichton@pnkfelix