Uh oh!
There was an error while loading. Please reload this page.
Changes to data produced by privacy pass - #29822
Conversation
bors
commented
Nov 17, 2015
☔ The latest upstream changes (presumably #29766) made this pull request unmergeable. Please resolve the merge conflicts. |
petrochenkov
commented
Nov 19, 2015
Updated. |
There was a problem hiding this comment.
This is some pretty slick usage of PartialOrd (and all the instances above)
alexcrichton
commented
Nov 20, 2015
Nice work, thanks @petrochenkov! (sorry for being a little slow to get to a review) Do you think that this'll need a crater run? It looks pretty straigtforward to me, but I'm curious if you ran across anything while working on it. Also just making sure, but you've given the docs a glance to make sure nothing major is missing? (e.g. |
petrochenkov
commented
Nov 20, 2015
Probably not (though, in a perfect world a crater run on every PR would be nice :)
Yes, I usually use |
alexcrichton
commented
Nov 20, 2015
bors
commented
Nov 20, 2015
This patch implements the plan described in https://internals.rust-lang.org/t/privacy-and-its-interaction-with-docs-lints-and-stability/2880 with one deviation. It turns out, that rustdoc needs the "directly public" set for its docs inlining logic, so the privacy pass have to produce three sets and not two. Three is arguably too many, so I merged them in one map: `public_items/exported_items/reachable_items: NodeSet => access_levels: NodeMap<AccessLevel>` r? @alexcrichton
bors
commented
Nov 20, 2015
Fixes#16734 and probably some other issues This is a continuation of #29822, but the algorithm is mostly a copy of #29973, so r? @alexcrichton or @nikomatsakis
This patch implements the plan described in https://internals.rust-lang.org/t/privacy-and-its-interaction-with-docs-lints-and-stability/2880 with one deviation.
It turns out, that rustdoc needs the "directly public" set for its docs inlining logic, so the privacy pass have to produce three sets and not two. Three is arguably too many, so I merged them in one map:
public_items/exported_items/reachable_items: NodeSet => access_levels: NodeMap<AccessLevel>r? @alexcrichton