resolve: fix bug in duplicate checking for extern crates by jseyfried · Pull Request #30295 · rust-lang/rust

jseyfried · 2015-12-10T05:07:44Z

Fix a bug allowing an item and an external crate to collide so long as the external crate is declared after the item. For example,

mod core {pubfnf(){}}// This would be an error if it followed the `extern crate`externcrate core;// This declaration is shadowed by the preceding modulefnmain(){ core::f();}

This is a [breaking-change], but it looks unlikely to cause breakage in practice, and any breakage can be fixed by removing colliding extern crate declarations, which are shadowed and hence unused.

rust-highfive · 2015-12-10T05:07:57Z

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

jseyfried · 2015-12-11T03:47:52Z

r? @nrc

nrc · 2015-12-11T04:23:56Z

r+

cc @rust-lang/compiler does this need a Crater run? I think not, but does anyone think we should?

nagisa · 2015-12-29T20:41:06Z

@nrc ping?

nrc · 2015-12-29T21:29:45Z

@bors: r+

bors · 2015-12-29T21:29:46Z

📌 Commit 0310a7a has been approved by nrc

bors · 2015-12-30T02:49:42Z

⌛ Testing commit 0310a7a with merge d91bf3f...

bors · 2015-12-30T04:20:30Z

💔 Test failed - auto-linux-64-nopt-t

nagisa · 2015-12-31T16:56:15Z

This cannot be merged anymore because in master, the type of this match statement has changed. While it still merges cleanly, it will not compile.

@nagisa Thanks for the diagnosis

jseyfried · 2016-01-07T01:17:12Z

@nrc rebased

nrc · 2016-01-07T01:34:02Z

@bors: r+

bors · 2016-01-07T01:34:03Z

📌 Commit 834fb17 has been approved by nrc

bors · 2016-01-07T03:19:55Z

⌛ Testing commit 834fb17 with merge 3917c98...

bors · 2016-01-07T04:44:13Z

💔 Test failed - auto-linux-64-nopt-t

brson · 2016-01-08T23:08:10Z

@bors retry

Fix a bug allowing an item and an external crate to collide so long as the external crate is declared after the item. For example, ```rust mod core { pub fn f() {} } // This would be an error if it followed the `extern crate` extern crate core; // This declaration is shadowed by the preceding module fn main() { core::f(); } ``` This is a [breaking-change], but it looks unlikely to cause breakage in practice, and any breakage can be fixed by removing colliding `extern crate` declarations, which are shadowed and hence unused.

bors · 2016-01-08T23:53:47Z

⌛ Testing commit 834fb17 with merge dfbb422...

pnkfelix · 2016-01-09T10:03:16Z

@bors retry force

pnkfelix · 2016-01-09T10:34:35Z

@bors r-

pnkfelix · 2016-01-09T10:34:45Z

@bors r=nrc force

bors · 2016-01-09T10:34:47Z

📌 Commit 834fb17 has been approved by nrc

…e, r=nrc Fix a bug allowing an item and an external crate to collide so long as the external crate is declared after the item. For example, ```rust mod core { pub fn f() {} } // This would be an error if it followed the `extern crate` extern crate core; // This declaration is shadowed by the preceding module fn main() { core::f(); } ``` This is a [breaking-change], but it looks unlikely to cause breakage in practice, and any breakage can be fixed by removing colliding `extern crate` declarations, which are shadowed and hence unused.

bors · 2016-01-11T02:07:45Z

⌛ Testing commit 834fb17 with merge c9b4826...

bors · 2016-01-11T02:09:24Z

💔 Test failed - auto-win-gnu-64-nopt-t

alexcrichton · 2016-01-11T04:12:03Z

@bors: retry

On Mon, Jan 11, 2016 at 3:09 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-win-gnu-64-nopt-t
http://buildbot.rust-lang.org/builders/auto-win-gnu-64-nopt-t/builds/2642
—
Reply to this email directly or view it on GitHub
#30295 (comment).

bors · 2016-01-11T06:40:59Z

⌛ Testing commit 834fb17 with merge 69e1f57...

Fix a bug allowing an item and an external crate to collide so long as the external crate is declared after the item. For example, ```rust mod core { pub fn f() {} } // This would be an error if it followed the `extern crate` extern crate core; // This declaration is shadowed by the preceding module fn main() { core::f(); } ``` This is a [breaking-change], but it looks unlikely to cause breakage in practice, and any breakage can be fixed by removing colliding `extern crate` declarations, which are shadowed and hence unused.

bors · 2016-01-11T08:32:45Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

rust-highfive assigned pnkfelix Dec 10, 2015

rust-highfive assigned nrc and unassigned pnkfelix Dec 11, 2015

nagisa mentioned this pull request Dec 31, 2015
Rollup of 4 pull requests #30660
Merged

nagisa reviewed Dec 31, 2015
View reviewed changes

jseyfried force-pushed the fix_extern_crate_duplicate branch 3 times, most recently from 8ae7d1b to 0c64ddaCompare January 6, 2016 02:06

Fix bug in duplicate checking for extern crates.
834fb17

jseyfried force-pushed the fix_extern_crate_duplicate branch from 0c64dda to 834fb17Compare January 6, 2016 07:07

nagisa mentioned this pull request Jan 9, 2016
Rollup of 5 pull requests #30793
Closed

bors merged commit 834fb17 into rust-lang:masterJan 11, 2016

jseyfried mentioned this pull request May 14, 2016
Name resolution has changed between 1.7.0 and 1.8.0 #33458
Closed

jseyfried deleted the fix_extern_crate_duplicate branch February 11, 2017 01:29

jseyfried changed the title ~~rustc_resolve: Fix bug in duplicate checking for extern crates.~~resolve: fix bug in duplicate checking for extern cratesFeb 14, 2017

coderabbitaiBot mentioned this pull request Jul 3, 2026
Unified client transport: datamancer-client crate with generic Client trait VoidstarSolutions/datamancer#11
Merged
3 tasks

Uh oh!

Uh oh!

Conversation

jseyfried commented Dec 10, 2015

Uh oh!

rust-highfive commented Dec 10, 2015

Uh oh!

jseyfried commented Dec 11, 2015

Uh oh!

nrc commented Dec 11, 2015

Uh oh!

nagisa commented Dec 29, 2015

Uh oh!

nrc commented Dec 29, 2015

Uh oh!

bors commented Dec 29, 2015

Uh oh!

bors commented Dec 30, 2015

Uh oh!

bors commented Dec 30, 2015

Uh oh!

nagisaDec 31, 2015

Choose a reason for hiding this comment

Uh oh!

jseyfriedJan 7, 2016

Choose a reason for hiding this comment

Uh oh!

jseyfried commented Jan 7, 2016

Uh oh!

nrc commented Jan 7, 2016

Uh oh!

bors commented Jan 7, 2016

Uh oh!

bors commented Jan 7, 2016

Uh oh!

bors commented Jan 7, 2016

Uh oh!

brson commented Jan 8, 2016

Uh oh!

bors commented Jan 8, 2016

Uh oh!

pnkfelix commented Jan 9, 2016

Uh oh!

pnkfelix commented Jan 9, 2016

Uh oh!

pnkfelix commented Jan 9, 2016

Uh oh!

bors commented Jan 9, 2016

Uh oh!

bors commented Jan 11, 2016

Uh oh!

bors commented Jan 11, 2016

Uh oh!

alexcrichton commented Jan 11, 2016

Uh oh!

bors commented Jan 11, 2016

Uh oh!

bors commented Jan 11, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants