Register new snapshots by alexcrichton · Pull Request #30352 · rust-lang/rust

alexcrichton · 2015-12-12T16:43:33Z

Lots of cruft to remove!

alexcrichton · 2015-12-12T16:43:38Z

r? @nikomatsakis

rust-highfive · 2015-12-12T16:43:38Z

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton · 2015-12-12T16:43:43Z

(or anyone else)

arielb1 · 2015-12-12T17:49:03Z

This version has a performance regression DO NOT SNAPSHOT UNTIL IT IS FIXED!

arielb1 · 2015-12-12T17:56:03Z

just kill the function. it has no reason for existing.

alexcrichton · 2015-12-12T18:21:13Z

@arielb1 oh hm, is there an issue for that? Depending on how much the snapshot is desired it may be worth making a snapshot before the regression (or just going ahead if the regression isn't that bad anyway)

dotdash · 2015-12-12T19:08:47Z

@alexcrichton I guess this might be about #30242 which apparently introduced a perf regression. There's no issue for that yet AFAICT.

gereeter · 2015-12-12T20:07:17Z

Comment should be removed?

Oops, it indeed can

pnkfelix · 2015-12-13T23:06:16Z

I think that #30368 is @arielb1 's PR to address the performance regression.

bors · 2015-12-18T17:09:21Z

☔ The latest upstream changes (presumably #30457) made this pull request unmergeable. Please resolve the merge conflicts.

alexcrichton · 2015-12-18T23:23:12Z

Rebased and updated with new snapshots that include #30368

nikomatsakis · 2015-12-20T11:42:53Z

@bors r+ p=1

Travis has been kind of flaky lately, eh? Is there a reason for that?

bors · 2015-12-20T11:42:54Z

📌 Commit afa656a has been approved by nikomatsakis

bors · 2015-12-20T11:42:55Z

⌛ Testing commit afa656a with merge 9bffee0...

bors · 2015-12-20T11:46:31Z

💔 Test failed - auto-win-gnu-32-opt

alexcrichton · 2015-12-20T16:37:49Z

@bors: retry

alexcrichton · 2015-12-20T16:39:05Z

@bors: r=nikomatsakis 34a75ea7abc6472498e91f7e7f2d7484429b7aa9

Actually travis seems to be pretty reliable for me at least as that's a test I needed to fix!

bors · 2015-12-20T19:21:19Z

⌛ Testing commit 34a75ea with merge 14cea44...

bors · 2015-12-20T20:07:55Z

💔 Test failed - auto-mac-64-nopt-t

Lots of cruft to remove!

alexcrichton · 2015-12-21T17:26:39Z

@bors: r=nikomatsakis cd1848a

bors · 2015-12-21T18:47:04Z

⌛ Testing commit cd1848a with merge 0c158e7...

bors · 2015-12-21T19:10:50Z

💔 Test failed - auto-mac-32-opt

alexcrichton · 2015-12-21T19:27:57Z

@bors: retry

On Mon, Dec 21, 2015 at 11:11 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-mac-32-opt
http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/7529
—
Reply to this email directly or view it on GitHub
#30352 (comment).

Lots of cruft to remove!

bors · 2015-12-21T21:37:27Z

⌛ Testing commit cd1848a with merge 2343a92...

bors · 2015-12-21T23:31:05Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

rust-highfive assigned aturon Dec 12, 2015

rust-highfive assigned nikomatsakis and unassigned aturon Dec 12, 2015

alexcrichton mentioned this pull request Dec 12, 2015
remove deprecated APIs missed in #30182 #30351
Merged

arielb1 reviewed Dec 12, 2015
View reviewed changes

Comment threadsrc/librustc_driver/lib.rs Outdated
arielb1Dec 12, 2015
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just kill the function. it has no reason for existing.

alexcrichton force-pushed the new-snashots branch from a4a212c to bbab661Compare December 12, 2015 18:20

gereeter reviewed Dec 12, 2015
View reviewed changes

alexcrichton force-pushed the new-snashots branch from bbab661 to 0e8ac4fCompare December 13, 2015 19:00

alexcrichton force-pushed the new-snashots branch from 0e8ac4f to f17e67eCompare December 18, 2015 23:22

alexcrichton force-pushed the new-snashots branch from f17e67e to afa656aCompare December 18, 2015 23:34

pnkfelix mentioned this pull request Dec 20, 2015
auto-win-gnu-32-opt bot is failing llvm build on MIPS header file #30496
Closed

alexcrichton force-pushed the new-snashots branch from afa656a to 34a75eaCompare December 20, 2015 16:38

Register new snapshots
cd1848a
Lots of cruft to remove!

alexcrichton force-pushed the new-snashots branch from 34a75ea to cd1848aCompare December 21, 2015 17:26

bors added a commit that referenced this pull request Dec 21, 2015
Auto merge of#30352- alexcrichton:new-snashots, r=nikomatsakis
2343a92
Lots of cruft to remove!

bors merged commit cd1848a into rust-lang:masterDec 21, 2015

bors mentioned this pull request Dec 21, 2015
Implement unwinding for i686 MSVC #30448
Merged

alexcrichton deleted the new-snashots branch December 22, 2015 05:09

Uh oh!

Uh oh!

Conversation

alexcrichton commented Dec 12, 2015

Uh oh!

alexcrichton commented Dec 12, 2015

Uh oh!

rust-highfive commented Dec 12, 2015

Uh oh!

alexcrichton commented Dec 12, 2015

Uh oh!

arielb1 commented Dec 12, 2015

Uh oh!

arielb1Dec 12, 2015

Choose a reason for hiding this comment

Uh oh!

alexcrichton commented Dec 12, 2015

Uh oh!

dotdash commented Dec 12, 2015

Uh oh!

gereeterDec 12, 2015

Choose a reason for hiding this comment

Uh oh!

alexcrichtonDec 13, 2015

Choose a reason for hiding this comment

Uh oh!

pnkfelix commented Dec 13, 2015

Uh oh!

bors commented Dec 18, 2015

Uh oh!

alexcrichton commented Dec 18, 2015

Uh oh!

nikomatsakis commented Dec 20, 2015

Uh oh!

bors commented Dec 20, 2015

Uh oh!

bors commented Dec 20, 2015

Uh oh!

bors commented Dec 20, 2015

Uh oh!

alexcrichton commented Dec 20, 2015

Uh oh!

alexcrichton commented Dec 20, 2015

Uh oh!

bors commented Dec 20, 2015

Uh oh!

bors commented Dec 20, 2015

Uh oh!

alexcrichton commented Dec 21, 2015

Uh oh!

bors commented Dec 21, 2015

Uh oh!

bors commented Dec 21, 2015

Uh oh!

alexcrichton commented Dec 21, 2015

Uh oh!

bors commented Dec 21, 2015

Uh oh!

bors commented Dec 21, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants