Skip to content

mk: fix undefined variable warnings - #30367

Merged
bors merged 1 commit into
rust-lang:masterfrom
tamird:fix-makefile-bugs
Feb 1, 2016
Merged

mk: fix undefined variable warnings#30367
bors merged 1 commit into
rust-lang:masterfrom
tamird:fix-makefile-bugs

Conversation

@tamird

@tamirdtamird commented Dec 13, 2015

Copy link
Copy Markdown
Contributor

Some of this is scary stuff. Probably time to lint against this.

Found with make --warn-undefined-variables.

r? @alexcrichton

@tamird
tamirdforce-pushed the fix-makefile-bugs branch 12 times, most recently from cc8f66d to 62c36feCompareDecember 13, 2015 22:08
@tamird

tamird commented Dec 13, 2015

Copy link
Copy Markdown
ContributorAuthor

@alexcrichton this is ready for a look

alexcrichton
alexcrichton reviewed Dec 14, 2015
View reviewed changes
Comment threadconfigure Outdated

@alexcrichtonalexcrichtonDec 14, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come these all changed? Do shells warn about this kind of thing?

@tamirdtamirdDec 14, 2015

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They don't warn; these had to change because of the addition of eval $V = 0 on L266

@bors

bors commented Dec 14, 2015

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #27937) made this pull request unmergeable. Please resolve the merge conflicts.

@tamird
tamirdforce-pushed the fix-makefile-bugs branch 2 times, most recently from 5dfcf99 to 521ffa4CompareDecember 16, 2015 19:16
@alexcrichton

alexcrichton commented Dec 16, 2015

Copy link
Copy Markdown
Member

The travis failure here seems worrisome?

@tamird

tamird commented Dec 16, 2015

Copy link
Copy Markdown
ContributorAuthor

Yeah, I'll take a look tomorrow; out of time for the day!

@tamird
tamirdforce-pushed the fix-makefile-bugs branch 2 times, most recently from 2b7dba4 to 5123218CompareDecember 17, 2015 03:33
@tamird
tamirdforce-pushed the fix-makefile-bugs branch 3 times, most recently from 62fc2df to b31fee8CompareJanuary 1, 2016 20:19
@tamird

tamird commented Jan 2, 2016

Copy link
Copy Markdown
ContributorAuthor

@alexcrichton PTAL. I've taken out the configure changes which were troublesome.

@alexcrichton

alexcrichton commented Jan 11, 2016

Copy link
Copy Markdown
Member

@bors: r+ b31fee8

@steveklabnik

steveklabnik commented Jan 11, 2016

Copy link
Copy Markdown
Contributor

Ah wonderful! I had looked into trying to do this a while back, and didn't do it. Bravo! 👍 💯

@tamird

tamird commented Jan 12, 2016

Copy link
Copy Markdown
ContributorAuthor

I think the failures here are legit, looking into it

@bors

bors commented Jan 14, 2016

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #30897) made this pull request unmergeable. Please resolve the merge conflicts.

@tamird

tamird commented Jan 25, 2016

Copy link
Copy Markdown
ContributorAuthor

Well, I wasn't able to reproduce any failures locally. Can I get another r+?

@alexcrichton

alexcrichton commented Jan 25, 2016

Copy link
Copy Markdown
Member

@bors: r+ 2b7a2db

@bors

bors commented Jan 25, 2016

Copy link
Copy Markdown
Collaborator

🙀 2b7a2db is not a valid commit SHA. Please try again with 2b6a2db.

@alexcrichton

alexcrichton commented Jan 25, 2016

Copy link
Copy Markdown
Member

@bors: r+ 2b6a2db

@bors

bors commented Jan 25, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 2b6a2db with merge b3037dd...

@bors

bors commented Jan 26, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-linux-64-x-android-t

@alexcrichtonalexcrichton self-assigned this Jan 27, 2016
@bors

bors commented Jan 30, 2016

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #31274) made this pull request unmergeable. Please resolve the merge conflicts.

@tamird

tamird commented Jan 31, 2016

Copy link
Copy Markdown
ContributorAuthor

@alexcrichton I believe I've fixed the android issue. Let's give it another go?

@alexcrichton

alexcrichton commented Jan 31, 2016

Copy link
Copy Markdown
Member

@bors: r+ 9a007093fa58d3a25002d2275f2fedef5af671c9

@bors

bors commented Feb 1, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9a00709 with merge 4d5b8d1...

@bors

bors commented Feb 1, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-linux-64-x-android-t

@tamird
mk: fix some undefined variable warnings
d037129
Some of this is scary stuff. Probably time to lint against this.
Found with `make --warn-undefined-variables`.
@tamird

tamird commented Feb 1, 2016

Copy link
Copy Markdown
ContributorAuthor

sigh, ifeq and $(if (...) are not interchangeable. once more, @alexcrichton? also, maybe it's ok to close this in light of #31123

@alexcrichton

alexcrichton commented Feb 1, 2016

Copy link
Copy Markdown
Member

Ah we can see if this works and take it from there

@bors: r+ d037129

@bors

bors commented Feb 1, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit d037129 with merge 7cae6b5...

bors added a commit that referenced this pull request Feb 1, 2016
@bors
Auto merge of#30367- tamird:fix-makefile-bugs, r=alexcrichton
7cae6b5
Some of this is scary stuff. Probably time to lint against this.
Found with `make --warn-undefined-variables`.
r? @alexcrichton
@bors

bors commented Feb 1, 2016

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors
bors merged commit d037129 into rust-lang:masterFeb 1, 2016
@borsbors mentioned this pull request Feb 1, 2016
Closed
@tamird
tamird deleted the fix-makefile-bugs branch February 1, 2016 21:25
@borsbors mentioned this pull request Feb 1, 2016
Merged
9 tasks
@alexcrichtonalexcrichton mentioned this pull request Feb 2, 2016
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tamird@bors@alexcrichton@steveklabnik@nagisa