Uh oh!
There was an error while loading. Please reload this page.
Used bold and italic in the markdown to make the stack and heap docum… - #30404
Conversation
rust-highfive
commented
Dec 15, 2015
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
huonw
commented
Dec 15, 2015
(I was thinking the colour could be done via |
steveklabnik
commented
Dec 15, 2015
Ah interesting! I like this idea. @Shiney , if it isn't too much work, would you mind:
Thank you! And yes, we could do colors inline. Let's see how this works and maybe do that in the future, depending. |
73a18d7 to
62fa40fCompareShiney
commented
Dec 16, 2015
Okay, I think I've done all the git voodo required to squash the commits to one commit... |
steveklabnik
commented
Dec 16, 2015
You have! Thanks so much. @bors: r+ rollup |
bors
commented
Dec 16, 2015
📌 Commit 62fa40f has been approved by |
…abnik …entation clearer I could not use colors as suggested for rust-lang#29854 because Github doesn't support these in markdown, however this solution may be better for color-blind readers.
…abnik …entation clearer I could not use colors as suggested for rust-lang#29854 because Github doesn't support these in markdown, however this solution may be better for color-blind readers.
…entation clearer
I could not use colors as suggested for #29854 because Github doesn't support these in markdown, however this solution may be better for color-blind readers.