Skip to content

std: Update jemalloc version - #30434

Merged
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:update-jemalloc
Dec 22, 2015
Merged

std: Update jemalloc version#30434
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:update-jemalloc

Conversation

@alexcrichton

@alexcrichtonalexcrichton commented Dec 17, 2015

Copy link
Copy Markdown
Member

It's been awhile since we last updated jemalloc, and there's likely some bugs
that have been fixed since the last version we're using, so let's try to update
again.

@rust-highfive

rust-highfive commented Dec 17, 2015

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

alexcrichton commented Dec 17, 2015

Copy link
Copy Markdown
MemberAuthor

I... forget the reason that this bounced in the past, and it may have been fixed upstream, so I figured we should try again.

@steveklabnik

steveklabnik commented Dec 17, 2015

Copy link
Copy Markdown
Contributor

@bors: r+

Let's refresh our memories.

@bors

bors commented Dec 17, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit aed7997 has been approved by steveklabnik

@bors

bors commented Dec 19, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit aed7997 with merge 8f431fa...

@bors

bors commented Dec 19, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-linux-64-nopt-t

@steveklabnik

steveklabnik commented Dec 19, 2015

Copy link
Copy Markdown
Contributor

@bors: retry

On Dec 19, 2015, 09:07 -0500, borsnotifications@github.com, wrote:

Test failed -auto-linux-64-nopt-t(http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/7421)

—
Reply to this email directly orview it on GitHub(#30434 (comment)).

@bors

bors commented Dec 19, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit aed7997 with merge a692b0d...

@bors

bors commented Dec 19, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-gnu-32-nopt-t

@sfackler

sfackler commented Dec 19, 2015

Copy link
Copy Markdown
Member

@bors retry

@bors

bors commented Dec 20, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit aed7997 with merge aa1075c...

@bors

bors commented Dec 20, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-gnu-32-nopt-t

@retep998

retep998 commented Dec 20, 2015

Copy link
Copy Markdown
Contributor

Both bot failures failed with the error code STATUS_RESOURCE_NOT_OWNED which is described as "{Application Error} The application attempted to release a resource it did not own. Click OK to terminate the application."

@alexcrichton

alexcrichton commented Dec 20, 2015

Copy link
Copy Markdown
MemberAuthor

@bors: r+ c0b868e133744dd0d23849671d818f5dcefe25ad

@bors

bors commented Dec 20, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c0b868e with merge 980c216...

@bors

bors commented Dec 20, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-gnu-64-opt

@alexcrichton
std: Update jemalloc version
9929c24
It's been awhile since we last updated jemalloc, and there's likely some bugs
that have been fixed since the last version we're using, so let's try to update
again.
@alexcrichton

alexcrichton commented Dec 21, 2015

Copy link
Copy Markdown
MemberAuthor

@bors: r+ 9929c24

@alexcrichton

alexcrichton commented Dec 21, 2015

Copy link
Copy Markdown
MemberAuthor

We're currently passing --enable-lazy-lock, but I think that's fundamentally broken on Windows, so I've switched it to an explicit --disable-lazy-lock (as it's enabled by default on MinGW). Local tests show that the failing tests here pass with a jemalloc built under that configuration, so I'm hoping that enables this to finally land!

@bors

bors commented Dec 21, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9929c24 with merge 5d4efcb...

bors added a commit that referenced this pull request Dec 21, 2015
@bors
Auto merge of#30434- alexcrichton:update-jemalloc, r=alexcrichton
5d4efcb
It's been awhile since we last updated jemalloc, and there's likely some bugs
that have been fixed since the last version we're using, so let's try to update
again.
@bors

bors commented Dec 22, 2015

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@borsbors mentioned this pull request Dec 22, 2015
Merged
@bors
bors merged commit 9929c24 into rust-lang:masterDec 22, 2015
@alexcrichton
alexcrichton deleted the update-jemalloc branch December 22, 2015 01:38
@alexcrichton

alexcrichton commented Dec 22, 2015

Copy link
Copy Markdown
MemberAuthor

🌴

@alexcrichtonalexcrichton added the relnotes Marks issues that should be documented in the release notes of the next release. label Dec 22, 2015
@alexcrichtonalexcrichton mentioned this pull request Dec 22, 2015
Closed
@alexcrichtonalexcrichton mentioned this pull request Jan 17, 2016
Merged
@MagaTailorMagaTailor mentioned this pull request Jan 18, 2016
Closed
@alexcrichtonalexcrichton mentioned this pull request Jan 19, 2016
Closed
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 20, 2016
@alexcrichton
Downgrade bundled jemalloc version
884de56
We've been seeing a lot of timeouts in tests on the bots and investigation ended
pointing to jemalloc/jemalloc#315 as the culprit. Unfortunately it looks like
that doesn't seem to have a fix on the way soon, so let's temporarily downgrade
back to the previous version of jemalloc we were using (where rust-lang#30434 was the
most recent upgrade)
bors added a commit that referenced this pull request Jan 20, 2016
@bors
Auto merge of#30985- alexcrichton:downgrade-jemaloc, r=brson
0b77e50
We've been seeing a lot of timeouts in tests on the bots and investigation ended
pointing to jemalloc/jemalloc#315 as the culprit. Unfortunately it looks like
that doesn't seem to have a fix on the way soon, so let's temporarily downgrade
back to the previous version of jemalloc we were using (where #30434 was the
most recent upgrade)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakisnikomatsakis

Labels

relnotesMarks issues that should be documented in the release notes of the next release.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@alexcrichton@rust-highfive@steveklabnik@bors@sfackler@retep998@nikomatsakis