Uh oh!
There was an error while loading. Please reload this page.
Make runtime function return size_t - #30454
Conversation
It returns sizeof(dirent_t), so I'm not sure why its return type is int. It's only used once, and that usage immediately casts it to usize.
rust-highfive
commented
Dec 18, 2015
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Apparently this file's use annotations have changed since I last pulled on my test machine.
alexcrichton
commented
Dec 18, 2015
bors
commented
Dec 20, 2015
⌛ Testing commit cf03cee with merge 0047d08... |
bors
commented
Dec 20, 2015
💔 Test failed - auto-mac-64-nopt-t |
alexcrichton
commented
Dec 20, 2015
@bors: retry On Sat, Dec 19, 2015 at 9:28 PM, bors notifications@github.com wrote:
|
It returns sizeof(dirent_t), so I'm not sure why its return type is int. It's only used once, and that usage immediately casts it to usize.
It returns sizeof(dirent_t), so I'm not sure why its return type is int.
It's only used once, and that usage immediately casts it to usize.