Uh oh!
There was an error while loading. Please reload this page.
Fix warnings when compiling stdlib with --test - #30458
Conversation
rust-highfive
commented
Dec 18, 2015
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
6d26750 to
a2019f2Comparesteveklabnik
commented
Dec 18, 2015
Looks good to me, but this isn't my specialty in the codebase, so I'll let someone else r+ |
There was a problem hiding this comment.
I think these cfg annotations should be combined, right?
a2019f2 to
d8a6eb5Comparefhahn
commented
Dec 20, 2015
@alexcrichton Thanks for your feedback! I've updated the commit. Now almost all warnings on Linux should be gone. The only remaining warnings are about the use of deprecated items in src/libstd/dynamic_lib.rs (https://github.com/rust-lang/rust/pull/30458/files#diff-59794c31034a5097419f3f376a30b4a4R135 and https://github.com/rust-lang/rust/pull/30458/files#diff-59794c31034a5097419f3f376a30b4a4R168), even though I've added |
d8a6eb5 to
aecbb5dCompareThere was a problem hiding this comment.
I think this may have slightly changed the semantics here as Answer lives over the call to panic!, but changing the declaration to let _answer = ... and removing the drop should have the same semantics.
alexcrichton
commented
Dec 21, 2015
Thanks @fhahn! Looks good to me! |
aecbb5d to
abe9b40Comparefhahn
commented
Dec 22, 2015
@alexcrichton thanks for your feedback! I've updated the PR again. |
alexcrichton
commented
Dec 23, 2015
@bors: r+ abe9b4088989912f0cfa2348e6a103131791f3df Thanks! |
bors
commented
Dec 23, 2015
⌛ Testing commit abe9b40 with merge efa0caf... |
bors
commented
Dec 23, 2015
💔 Test failed - auto-linux-64-x-android-t |
abe9b40 to
217bebbComparefhahn
commented
Dec 24, 2015
I've update the PR to fix the fail on android |
sanxiyn
commented
Dec 28, 2015
@bors r+ |
bors
commented
Dec 28, 2015
📌 Commit 217bebb has been approved by |
bors
commented
Dec 28, 2015
⌛ Testing commit 217bebb with merge 1d71545... |
bors
commented
Dec 28, 2015
💔 Test failed - auto-linux-64-x-android-t |
fhahn
commented
Dec 28, 2015
The build on Android fails, because I marked |
sanxiyn
commented
Dec 29, 2015
I agree they should match on Android too, but I think it could be done on a separate PR. |
217bebb to
e27cbefComparefhahn
commented
Dec 29, 2015
I've excluded the test from Android for now (at least I hope) and opened a PR for libc. After this lands, we should enable the test for android again. |
sanxiyn
commented
Dec 30, 2015
@bors r+ |
bors
commented
Dec 30, 2015
📌 Commit e27cbef has been approved by |
bors
commented
Dec 30, 2015
This PR siliences some warnings when compiling stdlib with --test. Mostly remove some unused imports and added a few `#[allow(..)]`. I also marked some signal handling functions with `#[cfg(not(test))]`, because they are only called through `rt::lang_start`, which is also marked as `#[cfg(not(test))]`
This PR siliences some warnings when compiling stdlib with --test. Mostly remove some unused imports and added a few
#[allow(..)].I also marked some signal handling functions with
#[cfg(not(test))], because they are only called throughrt::lang_start, which is also marked as#[cfg(not(test))]