Skip to content

Add help for E0514 - #30622

Closed
ticki wants to merge 1 commit into
rust-lang:masterfrom
ticki:E0514
Closed

Add help for E0514#30622
ticki wants to merge 1 commit into
rust-lang:masterfrom
ticki:E0514

Conversation

@ticki

Copy link
Copy Markdown
Contributor

Part of #30520

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Aatch (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@ticki

Copy link
Copy Markdown
ContributorAuthor

Fixes #30363

@ticki

ticki commented Jan 1, 2016

Copy link
Copy Markdown
ContributorAuthor

r? @arielb1

@rust-highfiverust-highfive assigned arielb1 and unassigned AatchJan 1, 2016
@arielb1

Copy link
Copy Markdown
Contributor

This is a little unclear. Maybe "consider recompiling it with this compiler"?

@ticki

ticki commented Jan 2, 2016

Copy link
Copy Markdown
ContributorAuthor

Well, it requires the user to explicitly removing the binaries, since they're compiled with an older compiler.

@arielb1

Copy link
Copy Markdown
Contributor

"the binaries" in this case sounds like the intended binary output of this compiler.

@GuillaumeGomez

Copy link
Copy Markdown
Member

@arielb1: Why not "consider recompiling it with your current rustc version"?

@bors

bors commented Jan 26, 2016

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #31065) made this pull request unmergeable. Please resolve the merge conflicts.

@steveklabnik

Copy link
Copy Markdown
Contributor

👍 to @GuillaumeGomez 's suggestion

@arielb1

Copy link
Copy Markdown
Contributor

r=me to that modulo a rebase

@ticki

ticki commented Feb 9, 2016

Copy link
Copy Markdown
ContributorAuthor

Sure thing.

@ticki

ticki commented Feb 9, 2016

Copy link
Copy Markdown
ContributorAuthor

Rebased.

@ticki

ticki commented Feb 9, 2016

Copy link
Copy Markdown
ContributorAuthor

goddammit lints.

@ticki

ticki commented Feb 9, 2016

Copy link
Copy Markdown
ContributorAuthor

Rebased again.

@arielb1

Copy link
Copy Markdown
Contributor
<syntax macros>:2:14: 2:70 error: no method named `span_help` found for type `&'a rustc::session::Session` in the current scope
<syntax macros>:2 { ( $ err ) . span_help ( $ span , & format ! ( $ ( $ message ) * ) ) ; } )

@ticki

Copy link
Copy Markdown
ContributorAuthor

The internal API must have changed. Have span_help! been renamed? If so, what is it named now.

@alexcrichton

Copy link
Copy Markdown
Member

Closing due to inactivity, but feel free to resubmit with the build errors fixed!

@GuillaumeGomezGuillaumeGomez mentioned this pull request Mar 8, 2016
bors added a commit that referenced this pull request Mar 11, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@ticki@rust-highfive@arielb1@GuillaumeGomez@bors@steveklabnik@alexcrichton@Aatch