Uh oh!
There was an error while loading. Please reload this page.
Update copyright date - #30665
Conversation
rust-highfive
commented
Dec 31, 2015
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
eddyb
commented
Jan 1, 2016
AFAIK we change the years only when we actually modify those files (not sure if |
panzarino
commented
Jan 1, 2016
Sorry, I didn't know. LICENSE-MIT and COPYRIGHT files should still be changed I can update this PR to only change those files if that's what you would like. |
hanna-kruppe
commented
Jan 1, 2016
@eddyb We don't even consistently update the years when modifying files. As one random example, |
frewsxcv
commented
Jan 1, 2016
These shouldn't be updated for the sake of being updated Previous discussion: #9070 |
eddyb
commented
Jan 1, 2016
@zachpanz88 If you want to work on this you could add support to src/etc/licenseck.py/src/etc/tidy.py to check the year based on the date of the git last commit. I would be glad to have these updated according to their changes. |
panzarino
commented
Jan 1, 2016
I have updated this PR to only change the @eddyb I can work on updating the files you mentioned above. You would want it to automatically update the comment at the top of the file to match the date at which the file was last updated correct? |
eddyb
commented
Jan 1, 2016
@zachpanz88 The scripts are supposed to check but not actually modify files. Auto-modification functionality would have to be separate. |
panzarino
commented
Jan 1, 2016
@eddyb Okay, so you want the program to check if the copyright date is the same as the last modified date and if not, display a message to the user. |
retep998
commented
Jan 1, 2016
Specifically those programs should cause make tidy to fail if they don't match, that way people would be forced to not forget. |
frewsxcv
commented
Jan 2, 2016
This pull request looks good to me with the latest changes |
nrc
commented
Jan 4, 2016
@bors: r+ rollup |
bors
commented
Jan 4, 2016
📌 Commit d5c8f62 has been approved by |
bors
commented
Jan 5, 2016
⌛ Testing commit d5c8f62 with merge ebc6ca8... |
bors
commented
Jan 5, 2016
💔 Test failed - auto-linux-64-nopt-t |
panzarino
commented
Jan 5, 2016
Not sure how that could have happened |
eddyb
commented
Jan 5, 2016
@zachpanz88 It's spurious, we've seen a lot of these lately. @bors retry |
bors
commented
Jan 5, 2016
New copyright date Happy new year!
New copyright date Happy new year!
New copyright date
Happy new year!