Uh oh!
There was an error while loading. Please reload this page.
run rustfmt on syntax::parse::lexer - #30684
Merged
Merged
Conversation
rust-highfive
commented
Jan 3, 2016
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
There was a problem hiding this comment.
Bad formatting. (Comment copied from the previous PR.)
MemberAuthor
There was a problem hiding this comment.
I prefer these in separate lines... I prefer what rustfmt did.
alexcrichton
commented
Jan 11, 2016
Member
r? @nrc |
nrc
commented
Jan 12, 2016
Member
There's a comment missing around line -1279/+1466 |
nrc
commented
Jan 12, 2016
Member
r+ with the missing comment addressed. |
tshepang
commented
Jan 12, 2016
MemberAuthor
r? @nrc |
tshepang
commented
Jan 12, 2016
MemberAuthor
That comment makes me a little confused... why is the shebang considered a comment? |
nrc
commented
Jan 12, 2016
Member
You can start a Rust program with a shebang, and it is ignored by Rust, i.e., treated as a comment. Only shells and so forth would process it. |
nrc
commented
Jan 12, 2016
Member
@bors: r+ |
bors
commented
Jan 12, 2016
Collaborator
📌 Commit aa3b4c6 has been approved by |
bors
commented
Jan 13, 2016
Collaborator
bors added a commit
that referenced
this pull request
Jan 13, 2016
bors
commented
Jan 13, 2016
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.