fix the docs and simplify the implementation of unsigned wrapping ops

[oli-obk]

r? @steveklabnik

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[steveklabnik]

The Travis failure looks legit here.

[oli-obk]

whoops. check-doc now passes locally.

[steveklabnik]

This comment makes no sense to me, why is it 'complete' to include something that doesn't make sense?

[oli-obk]

Yea, I should probably word that differently. Wrapped division on unsigned types is just normal division. There's no way wrapping could ever happen. So this function is here, so all operations are accounted for in the wrapping operations.

[steveklabnik]

Yeah, that sounds very reasonable, gotta find a better way to say that :)

[alexcrichton]

We may want to coordinate with #30466, looks like these are all touching similar surface area?

(I'll try to get around to rebasing and approving that today or tomorrow)

[oli-obk]

I'll just rebase after that PR, looks like just minor overlaps

[alexcrichton]

Sure, sounds good to me

[oli-obk]

apparently there was no overlap

[oli-obk]

I changed the wording, this is ready now.

[steveklabnik]

So, I am confused here with how said coordination went or should go, so r? @alexcrichton

[alexcrichton]

@bors: r+ 84a5790

Thanks!

[bors]

⌛ Testing commit 84a5790 with merge 2bd875d...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt