Skip to content

[MIR] Avoid some code generation for stores of ZST - #30848

Merged
bors merged 1 commit into
rust-lang:masterfrom
nagisa:mir-no-store-zsts
Jan 14, 2016
Merged

[MIR] Avoid some code generation for stores of ZST#30848
bors merged 1 commit into
rust-lang:masterfrom
nagisa:mir-no-store-zsts

Conversation

@nagisa

@nagisanagisa commented Jan 12, 2016

Copy link
Copy Markdown
Member

@nagisa

nagisa commented Jan 12, 2016

Copy link
Copy Markdown
MemberAuthor

Updated.

nagisa
nagisa reviewed Jan 12, 2016
View reviewed changes
Comment threadsrc/librustc_trans/trans/mir/operand.rs Outdated

@nagisanagisaJan 12, 2016

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops!

@nikomatsakis

nikomatsakis commented Jan 12, 2016

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Jan 12, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 20618d0 has been approved by nikomatsakis

@ManishearthManishearth mentioned this pull request Jan 13, 2016
Merged
@Manishearth

Manishearth commented Jan 14, 2016

Copy link
Copy Markdown
Member

This or #30845 caused http://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt/builds/2673/steps/test/logs/stdio

@ManishearthManishearth mentioned this pull request Jan 14, 2016
Merged
bors added a commit that referenced this pull request Jan 14, 2016
@bors
Auto merge of#30883- Manishearth:rollup, r=Manishearth
5b3a75f
- Successful merges: #30626, #30662, #30770, #30801, #30818, #30823, #30828, #30835, #30837, #30839, #30845, #30848, #30850, #30851, #30863
- Failed merges:
@bors

bors commented Jan 14, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 20618d0 with merge dce34e7...

@bors

bors commented Jan 14, 2016

Copy link
Copy Markdown
Collaborator

⛄ The build was interrupted to prioritize another pull request.

bors added a commit that referenced this pull request Jan 14, 2016
@bors
Auto merge of#30848- nagisa:mir-no-store-zsts, r=nikomatsakis
e5bab5d
Fixes#30831
r? @nikomatsakis
@bors

bors commented Jan 14, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 20618d0 with merge e5bab5d...

@bors

bors commented Jan 14, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-linux-64-nopt-t

@nagisa

nagisa commented Jan 14, 2016

Copy link
Copy Markdown
MemberAuthor

@bors retry

@bors

bors commented Jan 14, 2016

Copy link
Copy Markdown
Collaborator

⚡ Previous build results for auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-msvc-32-opt are reusable. Rebuilding only auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-64-opt...

@bors

bors commented Jan 14, 2016

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors
bors merged commit 20618d0 into rust-lang:masterJan 14, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakisnikomatsakis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nagisa@nikomatsakis@bors@Manishearth