Skip to content

Change some helps to suggestions - #31053

Closed
Manishearth wants to merge 3 commits into
rust-lang:masterfrom
Manishearth:help_suggestions
Closed

Change some helps to suggestions#31053
Manishearth wants to merge 3 commits into
rust-lang:masterfrom
Manishearth:help_suggestions

Conversation

@Manishearth

@ManishearthManishearth commented Jan 20, 2016

Copy link
Copy Markdown
Member

@eddyb

eddyb commented Jan 20, 2016

Copy link
Copy Markdown
Contributor

No tests?

@Manishearth

Manishearth commented Jan 20, 2016

Copy link
Copy Markdown
MemberAuthor

Pushed the test fixes. suggestion testing doesn't seem to work, the feature exists but it's not giving an error when I provide the wrong suggestion

@Manishearth

Manishearth commented Jan 20, 2016

Copy link
Copy Markdown
MemberAuthor

oh, the issue is that the other suggestion is hard to trigger, not sure the context in which resolve is set to emit_errors=false

oli-obk
oli-obk reviewed Jan 20, 2016
View reviewed changes
Comment threadsrc/librustc_lint/types.rs

@oli-obkoli-obkJan 20, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the cast way is the only one you can do generically. as -1isize as usize does not yield the same as !1usize. It would need to be !(x-1), which errors if x == 0

@ManishearthManishearthJan 20, 2016

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. Adding a generic cast here is harder so I'll just fix up the help message.

@bors

bors commented Jan 21, 2016

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #31010) made this pull request unmergeable. Please resolve the merge conflicts.

@Manishearth

Manishearth commented Jan 21, 2016

Copy link
Copy Markdown
MemberAuthor

Given that the unsigned one doesn't have a generic suggestion and the other one can't be triggered, closing

@Manishearth
Manishearth deleted the help_suggestions branch December 2, 2016 19:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@eddybeddyb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Manishearth@eddyb@bors@oli-obk