Skip to content

don't leak environment variables into test process - #31256

Merged
bors merged 1 commit into
rust-lang:masterfrom
oli-obk:patch-1
Jan 29, 2016
Merged

don't leak environment variables into test process#31256
bors merged 1 commit into
rust-lang:masterfrom
oli-obk:patch-1

Conversation

@oli-obk

@oli-obkoli-obk commented Jan 28, 2016

Copy link
Copy Markdown
Contributor

if the tests were run with RUST_BACKTRACE=1 make check this test failed. If they were run without RUST_BACKTRACE=1 it succeeded.

@rust-highfive

rust-highfive commented Jan 28, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@nagisa

nagisa commented Jan 28, 2016

Copy link
Copy Markdown
Member

@bors r+ rollup 97be317

@bors

bors commented Jan 28, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 97be317 has been approved by nagisa

@bors

bors commented Jan 28, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 97be317 with merge 1d4887e...

@bors

bors commented Jan 28, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-gnu-64-opt

@nagisa

nagisa commented Jan 28, 2016

Copy link
Copy Markdown
Member

The failure filled as #31259

@alexcrichton

alexcrichton commented Jan 28, 2016

Copy link
Copy Markdown
Member

I'd recommend an explicit env_remove instead of clearing all environment variables, that's unlikely to ever work on Windows unfortunately.

@oli-obk
don't leak RUST_BACKTRACE into test process
5012d20
If the tests were run with `RUST_BACKTRACE=1 make check` this test failed. If they were run without it it succeeded.
We need to use `env_remove` instead of `env_clear` because the latter will never work on windows
@oli-obk

oli-obk commented Jan 29, 2016

Copy link
Copy Markdown
ContributorAuthor

fixed

@nagisa

nagisa commented Jan 29, 2016

Copy link
Copy Markdown
Member

@bors r+ 5012d20

Manishearth added a commit to Manishearth/rust that referenced this pull request Jan 29, 2016
@Manishearth
Rollup merge ofrust-lang#31256- oli-obk:patch-1, r=nagisa
050c587
if the tests were run with `RUST_BACKTRACE=1 make check` this test failed. If they were run without `RUST_BACKTRACE=1` it succeeded.
@ManishearthManishearth mentioned this pull request Jan 29, 2016
Merged
bors added a commit that referenced this pull request Jan 29, 2016
@bors
Auto merge of#31285- Manishearth:rollup, r=Manishearth
61441cb
- Successful merges: #31252, #31256, #31264, #31269, #31272, #31275, #31276
- Failed merges:
@bors
bors merged commit 5012d20 into rust-lang:masterJan 29, 2016
@oli-obk
oli-obk deleted the patch-1 branch January 30, 2016 12:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakisnikomatsakis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@oli-obk@rust-highfive@nagisa@bors@alexcrichton@nikomatsakis