Uh oh!
There was an error while loading. Please reload this page.
Remove "powerpc64le" and "mipsel" target_arch - #31312
Merged
Merged
Conversation
rust-highfive
commented
Jan 30, 2016
Contributor
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
commented
Jan 30, 2016
MemberAuthor
r? @brson There was a little discussion which led to this conclusion, and I believe this is not a breaking change because |
brson
commented
Feb 2, 2016
Contributor
@bors r+ |
bors
commented
Feb 2, 2016
Collaborator
📌 Commit 4c4ab1d has been approved by |
bors
commented
Feb 2, 2016
Collaborator
⌛ Testing commit 4c4ab1d with merge 20b6b58... |
bors
commented
Feb 2, 2016
Collaborator
💔 Test failed - auto-linux-64-nopt-t |
Currently the `mipsel-unknown-linux-gnu` target doesn't actually set the `target_arch` value to `mipsel` but it rather uses `mips`. Alternatively the `powerpc64le` target does indeed set the `target_arch` as `powerpc64le`, causing a bit of inconsistency between theset two. As these are just the same instance of one instruction set, let's use `target_endian` to switch between them and only set the `target_arch` as one value. This should cut down on the number of `#[cfg]` annotations necessary and all around be a little more ergonomic.
alexcrichtonforce-pushed
the
no-le-in-powerpc64le
branch
from
February 2, 2016 04:39
4c4ab1d to
8f803c2Comparealexcrichton
commented
Feb 2, 2016
MemberAuthor
bors
commented
Feb 2, 2016
Collaborator
bors added a commit
that referenced
this pull request
Feb 2, 2016
Currently the `mipsel-unknown-linux-gnu` target doesn't actually set the `target_arch` value to `mipsel` but it rather uses `mips`. Alternatively the `powerpc64le` target does indeed set the `target_arch` as `powerpc64le`, causing a bit of inconsistency between theset two. As these are just the same instance of one instruction set, let's use `target_endian` to switch between them and only set the `target_arch` as one value. This should cut down on the number of `#[cfg]` annotations necessary and all around be a little more ergonomic.
bors
commented
Feb 2, 2016
Collaborator
bors
commented
Feb 2, 2016
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
mipsel-unknown-linux-gnutarget doesn't actually set thetarget_archvalue tomipselbut it rather usesmips. Alternatively thepowerpc64letarget does indeed set thetarget_archaspowerpc64le,causing a bit of inconsistency between theset two.
As these are just the same instance of one instruction set, let's use
target_endianto switch between them and only set thetarget_archas onevalue. This should cut down on the number of
#[cfg]annotations necessary andall around be a little more ergonomic.