Skip to content

Fix E0118 - #31347

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:fix_E0118
Feb 3, 2016
Merged

Fix E0118#31347
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:fix_E0118

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Feb 1, 2016

Copy link
Copy Markdown
Member

eddyb
eddyb reviewed Feb 1, 2016
View reviewed changes
Comment threadsrc/librustc_typeck/diagnostics.rs Outdated

@eddybeddybFeb 1, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type alias seems superfluous, and it's irrelevant to the error itself.

@GuillaumeGomezGuillaumeGomezFeb 1, 2016

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll also say that you can't implement a type which isn't defined in the current crate.

@ManishearthManishearthFeb 1, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type aliases don't change the situation at all, they're just confusing here since it seems like you're suggesting them as a solution even if they won't work.

@eddyb

eddyb commented Feb 1, 2016

Copy link
Copy Markdown
Contributor

cc @Manishearth

@GuillaumeGomez
GuillaumeGomezforce-pushed the fix_E0118 branch 4 times, most recently from 171f3c0 to 994ed2aCompareFebruary 2, 2016 18:58
Manishearth
Manishearth reviewed Feb 2, 2016
View reviewed changes
Comment threadsrc/librustc_typeck/coherence/orphan.rs Outdated

@ManishearthManishearthFeb 2, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the stuff after the semicolon should be in a help

Manishearth
Manishearth reviewed Feb 2, 2016
View reviewed changes
Comment threadsrc/librustc_typeck/coherence/orphan.rs Outdated

@ManishearthManishearthFeb 2, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two should be linked using struct_span_err.

@GuillaumeGomez

GuillaumeGomez commented Feb 2, 2016

Copy link
Copy Markdown
MemberAuthor

Updated.

@Manishearth

Manishearth commented Feb 2, 2016

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Feb 2, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit db63a55 has been approved by Manishearth

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 2, 2016
@Manishearth
Rollup merge ofrust-lang#31347- GuillaumeGomez:fix_E0118, r=Manishe…
688f607
…arth
r? @eddyb
@ManishearthManishearth mentioned this pull request Feb 2, 2016
Merged
bors added a commit that referenced this pull request Feb 3, 2016
@bors
Auto merge of#31370- Manishearth:rollup, r=Manishearth
a992241
- Successful merges: #27499, #31220, #31329, #31332, #31347, #31351, #31352, #31366
- Failed merges:
@bors
bors merged commit db63a55 into rust-lang:masterFeb 3, 2016
@GuillaumeGomez
GuillaumeGomez deleted the fix_E0118 branch February 3, 2016 07:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@eddybeddyb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez@eddyb@Manishearth@bors