Uh oh!
There was an error while loading. Please reload this page.
Resolve: stop letting items shadow reexported glob imports - #31376
Closed
jseyfried wants to merge 1 commit into
Closed
Resolve: stop letting items shadow reexported glob imports#31376jseyfried wants to merge 1 commit into
jseyfried wants to merge 1 commit into
Conversation
jseyfriedforce-pushed
the
disallow_shadowing
branch
2 times, most recently
from
February 3, 2016 05:18
ae640ef to
a118b6aComparenrc
commented
Feb 3, 2016
Member
cc @rust-lang/lang |
jseyfriedforce-pushed
the
disallow_shadowing
branch
from
February 3, 2016 06:28
a118b6a to
1c9446fCompareretep998
commented
Feb 3, 2016
Contributor
Per my other comment here a crater run wouldn't notice breakages to projects that glob import winapi. |
petrochenkov
commented
Feb 3, 2016
Contributor
Yeah, the breakage looks bad (still would be interested to see crater results). |
bors
commented
Feb 11, 2016
Collaborator
☔ The latest upstream changes (presumably #31461) made this pull request unmergeable. Please resolve the merge conflicts. |
jseyfriedforce-pushed
the
disallow_shadowing
branch
3 times, most recently
from
February 11, 2016 08:10
03d9c78 to
1ae0233Comparejseyfried
commented
Feb 12, 2016
ContributorAuthor
rebased |
nikomatsakis
commented
Feb 12, 2016
Contributor
Since we decided not to "fix" the current behavior, I believe this PR should be closed. Correct me if I am mistaken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stops non-import items from shadowing glob-imported re-exports (fixes#31337) and fixes the fallout in the standard libraries and tests.
Previously, it was possible to shadow a glob-imported re-export, so this a [breaking-chage]. For example,
The breakage can be fixed by renaming the non-import item or by using single imports in place of the glob import.
r? @nrc