Uh oh!
There was an error while loading. Please reload this page.
Update variance dep. graph edges to be more fine-grained - #31394
Merged
Conversation
nikomatsakisforce-pushed
the
incr-comp-variance
branch
from
February 3, 2016 21:35
1770e2e to
bd31812Comparenikomatsakis
commented
Feb 3, 2016
ContributorAuthor
done. |
nikomatsakis
commented
Feb 3, 2016
ContributorAuthor
cc @michaelwoerister (just b/c it's related to incr. comp.) |
nikomatsakisforce-pushed
the
incr-comp-variance
branch
2 times, most recently
from
February 3, 2016 21:54
97612e2 to
ade4a76Comparenikomatsakis
commented
Feb 4, 2016
ContributorAuthor
Travis failure looks bogus (this branch passes |
Contributor
There was a problem hiding this comment.
"we record map" ?
was that supposed to just be "we map" ?
bors
commented
Feb 5, 2016
Collaborator
☔ The latest upstream changes (presumably #31304) made this pull request unmergeable. Please resolve the merge conflicts. |
nikomatsakis
commented
Feb 10, 2016
ContributorAuthor
@pnkfelix did you complete your review here? |
pnkfelix
commented
Feb 10, 2016
Contributor
@nikomatsakis no i think I need to return to it |
map. Perhaps I ought to just add them instead, but this seems harmless enough.
be more fine-grained, fixing the `dep-graph-struct-signature` test.
nikomatsakisforce-pushed
the
incr-comp-variance
branch
from
February 18, 2016 10:28
ade4a76 to
01ebc37Comparenikomatsakis
commented
Feb 18, 2016
ContributorAuthor
@pnkfelix rebased |
pnkfelix
commented
Feb 18, 2016
Contributor
@bors r+ |
bors
commented
Feb 18, 2016
Collaborator
📌 Commit 01ebc37 has been approved by |
bors
commented
Feb 18, 2016
Collaborator
bors
commented
Feb 18, 2016
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the dep. graph edges created by variance just mirror the constraint graph.
Note that this extends #31304, so the first few commits are on a different topic.
r? @pnkfelix