Uh oh!
There was an error while loading. Please reload this page.
Clarify scenario where AsciiExt appears to operate on non-ASCII - #31401
Conversation
rust-highfive
commented
Feb 4, 2016
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
frewsxcv
commented
Feb 4, 2016
There was a problem hiding this comment.
Showing the imports is considered better nowadays.
steveklabnik
commented
Feb 4, 2016
Thanks so much! A few nits, and also, could you wrap this to 80 cols, not 100? |
frewsxcv
commented
Feb 4, 2016
Comments have been addressed |
steveklabnik
commented
Feb 4, 2016
@bors: r+ rollup thanks so much |
bors
commented
Feb 4, 2016
📌 Commit 93d6425 has been approved by |
Fixes#31203