Allow registering MIR-passes through compiler plugins

[oli-obk]

depends on #31324

r? @nagisa

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nagisa (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[nagisa]

This looks okay to me.

EDIT: r=me once the dependency lands/is r+d.

[bors]

☔ The latest upstream changes (presumably #31307) made this pull request unmergeable. Please resolve the merge conflicts.

[nagisa]

Rebase?

[oli-obk]

done

[nagisa]

@bors r+ 4b06718

[bors]

⌛ Testing commit 4b06718 with merge 3ea4605...

[bors]

💔 Test failed - auto-linux-64-opt

[oli-obk]

no clue where that error came from:

error: error pattern ' build without -C codegen-units for more exact errors' not found!
status: exit code: 101
command: x86_64-unknown-linux-gnu/stage2/bin/rustc /buildslave/rust-buildbot/slave/auto-linux-64-opt/build/src/test/compile-fail/asm-src-loc-codegen-units.rs -L x86_64-unknown-linux-gnu/test/compile-fail/ --target=x86_64-unknown-linux-gnu -L x86_64-unknown-linux-gnu/test/compile-fail/asm-src-loc-codegen-units.stage2-x86_64-unknown-linux-gnu.compile-fail.libaux -C prefer-dynamic -o x86_64-unknown-linux-gnu/test/compile-fail/asm-src-loc-codegen-units.stage2-x86_64-unknown-linux-gnu --cfg rtopt -C rpath -O -L x86_64-unknown-linux-gnu/rt -C codegen-units=2
stdout:
------------------------------------------
------------------------------------------
stderr:
------------------------------------------
thread 'error: codegen-1<inline asm>:1:2: error: invalid instruction mnemonic 'nowayisthisavalidinstruction'
nowayisthisavalidinstruction
^
' panicked at 'Box<Any>', ../src/libsyntax/errors/mod.rs:note607: build without -C codegen-units for more exact errorsnote: Run with `RUST_BACKTRACE=1` for a backtrace.
error: aborting due to previous error
error: aborting due to worker thread panic
------------------------------------------
thread '[compile-fail] compile-fail/asm-src-loc-codegen-units.rs' panicked at 'explicit panic', /buildslave/rust-buildbot/slave/auto-linux-64-opt/build/src/compiletest/runtest.rs:1527
note: Run with `RUST_BACKTRACE=1` for a backtrace.
failures:
[compile-fail] compile-fail/asm-src-loc-codegen-units.rs

[nagisa]

@bors retry

Seems spurious to me: the error message is 2 different error messages interleaved which makes the actual error we’re looking for invalid.

[arielb1]

@bors retry

[bors]

⌛ Testing commit 4b06718 with merge 096dbf8...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

[nrc]

What is the motivation for this? It would be nice if changes like this could get some discussion - an internals thread, or even an issue being opened beforehand. I feel we have been burnt by llvm plugin passes and don't want to repeat that experience. At the very least this facility should be documented.

[oli-obk]

Sorry about that. Discussion start: https://internals.rust-lang.org/t/mir-compiler-plugins-for-custom-mir-passes/3166