Skip to content

Start documenting BTreeMap's node interface - #31441

Merged
bors merged 2 commits into
rust-lang:masterfrom
gereeter:btree-docs
Apr 17, 2016
Merged

Start documenting BTreeMap's node interface#31441
bors merged 2 commits into
rust-lang:masterfrom
gereeter:btree-docs

Conversation

@gereeter

@gereetergereeter commented Feb 6, 2016

Copy link
Copy Markdown
Contributor

@rust-highfive

rust-highfive commented Feb 6, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton

alexcrichton commented Feb 6, 2016

Copy link
Copy Markdown
Member

r? @gankro

@Gankra

Gankra commented Feb 6, 2016

Copy link
Copy Markdown
Contributor

💖

Gankra
Gankra reviewed Feb 6, 2016
View reviewed changes
Comment threadsrc/libcollections/btree/node.rs Outdated
// - Trees must have uniform depth/height. This means that every path down to a leaf from a
// given node has exactly the same length.
// - A node of length `n` has `n` keys, `n` values, and (in an internal node) `n + 1` edges.
// This implies that even an empty node has at least one edge.

@GankraGankraFeb 6, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty internal node

@Gankra

Gankra commented Feb 6, 2016

Copy link
Copy Markdown
Contributor

Done review

@gereeter

gereeter commented Feb 25, 2016

Copy link
Copy Markdown
ContributorAuthor

Sorry for being slow about this - I've been busy with schoolwork. I think I dealt with all your comments.

@bluss

bluss commented Apr 15, 2016

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Apr 15, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit fa8556e has been approved by bluss

@bluss

bluss commented Apr 15, 2016

Copy link
Copy Markdown
Contributor

@bors rollup

@bors

bors commented Apr 16, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit fa8556e with merge c67dc08...

@bors

bors commented Apr 16, 2016

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-win-gnu-32-opt-rustbuild

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@GankraGankra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gereeter@rust-highfive@alexcrichton@Gankra@bluss@bors