Uh oh!
There was an error while loading. Please reload this page.
[breaking batch] don't glob-export syntax::abi enums - #31485
Conversation
rust-highfive
commented
Feb 8, 2016
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Manishearth
commented
Feb 8, 2016
While we're at it, should we also un-batch export |
Manishearth
commented
Feb 8, 2016
cc @erickt heads up |
oli-obk
commented
Feb 8, 2016
I'm creating a bunch of these PRs, then you can roll them up. Feels free to open an issue with checkboxes of things that should be done, in an order that your prefer. |
Manishearth
commented
Feb 8, 2016
Nah, this works |
Manishearth
commented
Feb 8, 2016
r+ on this one |
bluss
commented
Feb 8, 2016
Should it have the ususal |
Manishearth
commented
Feb 8, 2016
the [breaking-batch] is for batching up breaking libsyntax changes |
bluss
commented
Feb 8, 2016
Is this a breaking change in the usual sense of |
Manishearth
commented
Feb 8, 2016
Well, breaking libsyntax. Not sure if that qualifies as breaking; since many compiler changes break internals and we don't mark that as breaking either. |
oli-obk
commented
Feb 8, 2016
I'll mark it. |
oli-obk
commented
Feb 8, 2016
merged into #31487 |
r? @Manishearth