Skip to content

Rename ClosureKind variants and stop re-exporting them. - #31606

Merged
bors merged 1 commit into
rust-lang:masterfrom
Ms2ger:ClosureKind
Mar 8, 2016
Merged

Rename ClosureKind variants and stop re-exporting them.#31606
bors merged 1 commit into
rust-lang:masterfrom
Ms2ger:ClosureKind

Conversation

@Ms2ger

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@oli-obk

Copy link
Copy Markdown
Contributor

the commit message needs a [breaking-change]

@nikomatsakis

Copy link
Copy Markdown
Contributor

I'm not convinced this sort of change out to be tagged with [breaking-change]. It's one thing to tag changes to libsyntax which (unfortunately, in my view) has a kind of "semi-stable" status, but the internals of rustc don't fall in that category.

@oli-obk

Copy link
Copy Markdown
Contributor

it's reachable from late lints, I just assumed that any change observable from plugins would require the mark so we can find the commits easily

@Ms2ger

Copy link
Copy Markdown
ContributorAuthor

I can see the argument for including it, but I haven't done that with similar changes I made earlier. Happy to go either way.

@alexcrichton

Copy link
Copy Markdown
Member

r? @eddyb (or anyone else from the compilers team)

@alexcrichtonalexcrichton assigned eddyb and unassigned brsonMar 8, 2016
@eddyb

eddyb commented Mar 8, 2016

Copy link
Copy Markdown
Contributor

Pretty! @bors r+

@bors

bors commented Mar 8, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit c6474af has been approved by eddyb

@bors

bors commented Mar 8, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c6474af with merge a9ffe67...

bors added a commit that referenced this pull request Mar 8, 2016
Rename ClosureKind variants and stop re-exporting them.
@bors
bors merged commit c6474af into rust-lang:masterMar 8, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@Ms2ger@rust-highfive@oli-obk@nikomatsakis@alexcrichton@eddyb@bors@brson