Uh oh!
There was an error while loading. Please reload this page.
Update timespec comments to say "nanoseconds" - #3182
Closed
cpeterso wants to merge 1 commit into
Closed
Conversation
brson
commented
Aug 11, 2012
Contributor
Thanks! I've pushed this commit to the incoming branch. It will show up on master sometime this week. |
RalfJung pushed a commit
to RalfJung/rust
that referenced
this pull request
Nov 25, 2023
RalfJung pushed a commit
to RalfJung/rust
that referenced
this pull request
Nov 25, 2023
jaisnan pushed a commit
to jaisnan/rust-dev
that referenced
this pull request
Jul 29, 2024
typed_swap needs to be a no-op on ZSTs as pointers to those have an arbitrary value in Kani. Resolves: rust-lang#3182
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
4280: Add documents owner for ImplDef and SourceFile r=matklad a=edwin0cheng When working on rust-lang#3182, I found that `ImplDef` and `SourceFile` do not implemet `DocCommentsOwer` trait, and I tested it in `cargo doc` that `impl` could has some doc-comments. I am not so sure about `SourceFile` case, but in theory if that file is a crate root, the doc comment of it should represent the whole crate documentation, right ? Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
4660: Enable hover and autocomplete docs on macro generated items r=aloucks a=aloucks Enable hover and autocomplete docs on macro generated items. This de-sugars doc comments into `doc` attributes in some cases, but not all. Comments and `doc` attributes are then merged together. This PR is essentially a partial implementation of what's being suggested rust-lang#3182, but it's not all the way there yet. ~I still need to add unit tests~, but I wanted to first get feedback on whether or not this was an acceptable path forward. Fixesrust-lang#4564Fixesrust-lang#3984Fixesrust-lang#3180 Related rust-lang#3182  Co-authored-by: Aaron Loucks <aloucks@cofront.net>
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
6750: Remove documentation query, move doc handling to attributes r=matklad a=Veykril Fixesrust-lang#3182 Removes the documentation query in favor of `Attrs::docs`. Attrs already handlded doc comments partially but the alloc saving check was wrong so it only worked when other attributes existed as well. Unfortunately the `new` constructor has to do an intermediate allocation now because we need to keep the order of mixed doc attributes and doc comments. I've also partially adjusted the `hover` module to have its tests check the changes, it still has some `HasSource` trait usage due to the `ShortLabel` trait usage, as that is only implemented on the Ast parts and not the Hir, should this ideally be implemented for the Hir types as well?(would be a follow up PR of course) Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
timespec uses nanoseconds, but its comments still refer to (timeval's) microseconds.