Uh oh!
There was an error while loading. Please reload this page.
Add f32 and f64 examples warning - #31918
Conversation
steveklabnik
commented
Feb 26, 2016
So, you put it this way because the examples are kinda random, right? Would it be better to pick one, and make all examples use it, and then only need the disclaimer for one of them? I'm not sure. |
GuillaumeGomez
commented
Feb 26, 2016
I found it better this way because as long as examples are common for |
steveklabnik
commented
Feb 26, 2016
Right, but right now, in f32 it says "the examples are f64" and in f64 it says "the examples are f32". If they're common they should be just one type, no? Or maybe we're just agreeing and slightly misunderstanding each other :) |
GuillaumeGomez
commented
Feb 26, 2016
Haha, I see your point. I rewrite it. :) |
There was a problem hiding this comment.
How about "please note that examples are shared between the f64"...
steveklabnik
commented
Feb 26, 2016
One tiny wording tweak (for both, though I just left the comment on one) and then let's |
steveklabnik
commented
Feb 26, 2016
@bors: r+ rollup 🎊 ❤️ |
bors
commented
Feb 26, 2016
📌 Commit 25c62eb has been approved by |
r? @steveklabnik
Fixes#29334