Uh oh!
There was an error while loading. Please reload this page.
Rename middle::ty::ctxt to TyCtxt - #31979
Conversation
KalitaAlexey
commented
Mar 1, 2016
Why do we need namespaces if we are not using them? |
jseyfried
commented
Mar 1, 2016
We need namespaces because we often do use them. That doesn't mean we should always avoid more descriptive names just because namespaces allow it. In this case, I decided to use |
KalitaAlexey
commented
Mar 1, 2016
@jseyfried you can write |
jseyfried
commented
Mar 1, 2016
True, but I would prefer to be consistent with the other contexts. Also, that would make it harder to grep for all uses of |
eddyb
commented
Mar 1, 2016
cc @nikomatsakis There is that dual type context (w/ multiple lifetimes) refactor I wanted to do ages ago, which also renamed the context, but I used |
KalitaAlexey
commented
Mar 1, 2016
@jseyfried It wouldn't make harder to grep. Or I don't understood you. |
jseyfried
commented
Mar 1, 2016
@KalitaAlexey You would have to grep for both |
KalitaAlexey
commented
Mar 1, 2016
Ok. You said |
bors
commented
Mar 1, 2016
☔ The latest upstream changes (presumably #31962) made this pull request unmergeable. Please resolve the merge conflicts. |
nikomatsakis
commented
Mar 2, 2016
On Mon, Feb 29, 2016 at 11:48:26PM -0800, Eduard-Mihai Burtescu wrote:
It seems like the precedent is to call the type |
eddyb
commented
Mar 2, 2016
Well then, it's not like it could make refactorings any harder (actually, it should be easier to grep for |
8189937 to
5623a95Comparejseyfried
commented
Mar 3, 2016
@eddyb rebased, the travis build is successful now |
eddyb
commented
Mar 3, 2016
@bors r+ |
bors
commented
Mar 3, 2016
📌 Commit 37ba66a has been approved by |
r? @eddyb