Explained the difference between ownership iteration and reference iteration by srinivasreddy · Pull Request #32002 · rust-lang/rust

srinivasreddy · 2016-03-02T04:08:00Z

Issue here : #31991

…eration

rust-highfive · 2016-03-02T04:08:16Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Manishearth · 2016-03-02T05:01:55Z

 println!("Take ownership of the vector and its element {}", i);
 }
 ```
+Note: You cannot use the vector again once you have iterated with ownership of the vector.


iterated by taking ownership of the vector

(Also, please put a newline above this line as well)

steveklabnik · 2016-03-02T14:33:46Z

Thanks so much @srinivasreddy ! I like @Manishearth 's grammar suggestions, and I have some whitespace ones as well. We're good to go after that's fixed up!

srinivasreddy · 2016-03-02T15:07:59Z

@steveklabnik Welcome!! @Manishearth Please review and merge

Manishearth · 2016-03-02T15:10:12Z

+}
+
+for i in &v {
+ println!("This is a reference {}", i);


make this text match the previous

srinivasreddy · 2016-03-02T15:13:29Z

@Manishearth Done

Manishearth · 2016-03-02T15:15:01Z

@bors r+ rollup

bors · 2016-03-02T15:15:02Z

📌 Commit 2dc723d has been approved by Manishearth

Manishearth · 2016-03-02T15:15:05Z

Thanks!

srinivasreddy · 2016-03-03T06:08:00Z

@Manishearth I am new to travis. Do you see any reason for build failure? Could you please help me ?

Manishearth · 2016-03-03T06:57:06Z

+You can iterate the vector multiple times by taking a reference to the vector whilst iterating. 
+For example, the following code does not compile.
+
+```rust


you need to have rust,ignore here

@Manishearth Done. Please issue auto merge

Manishearth · 2016-03-03T06:58:06Z

Ah, in this case the doctest failed. Rust code in documentation is compiled and run as a test, so your example of failing code should be annotated as mentioned above to skip this.

bors · 2016-03-03T13:17:11Z

⌛ Testing commit 2dc723d with merge 02c4cb5...

bors · 2016-03-03T14:23:05Z

💔 Test failed - auto-linux-64-opt

Manishearth · 2016-03-03T17:54:10Z

@bors r+ rollup

bors · 2016-03-03T17:54:11Z

📌 Commit d2df551 has been approved by Manishearth

srinivasreddy · 2016-03-04T06:29:06Z

@Manishearth Please merge. Or could @bors automatically merge this?

Manishearth · 2016-03-04T06:33:51Z

Yes. Bors will run tests on the CI and automatically merge if they pass, like last time.

Manishearth · 2016-03-04T06:34:23Z

There's a queue (http://buildbot.rust-lang.org/homu/queue/rust), so it might take some time for your PR to get merged.

…arth Issue here : rust-lang#31991

- Successful merges: #32002, #32017, #32027, #32035, #32036 - Failed merges:

Explained the difference between ownership iteration and reference it…
9bf73d2
…eration

rust-highfive assigned Manishearth Mar 2, 2016

srinivasreddy changed the title ~~Explained the difference between ownership iteration and reference it…~~Explained the difference between ownership iteration and reference iterationMar 2, 2016

Manishearth reviewed Mar 2, 2016
View reviewed changes

addressed review comments - grammar corrections, space additions
a3c9afa

Manishearth reviewed Mar 2, 2016
View reviewed changes

made print message similar across two loops
2dc723d

Manishearth reviewed Mar 3, 2016
View reviewed changes

added ignore
d2df551

srinivasreddy mentioned this pull request Mar 4, 2016
Rollup of 4 pull requests #32037
Closed

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 4, 2016
Rollup merge ofrust-lang#32002- srinivasreddy:vector_doc, r=Manishe…
75c14e1
…arth Issue here : rust-lang#31991

Manishearth mentioned this pull request Mar 4, 2016
Rollup of 8 pull requests #32038
Closed

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Mar 4, 2016
Rollup merge ofrust-lang#32002- srinivasreddy:vector_doc, r=Manishe…
55bc488
…arth Issue here : rust-lang#31991

steveklabnik mentioned this pull request Mar 4, 2016
Rollup of 5 pull requests #32046
Merged

bors added a commit that referenced this pull request Mar 4, 2016
Auto merge of#32046- steveklabnik:rollup, r=steveklabnik
da0ccd8
- Successful merges: #32002, #32017, #32027, #32035, #32036 - Failed merges:

alexcrichton merged commit d2df551 into rust-lang:masterMar 5, 2016

srinivasreddy deleted the vector_doc branch March 5, 2016 17:23

srinivasreddy mentioned this pull request Mar 7, 2016
Explain different types of iteration #31991
Closed

Uh oh!

Uh oh!

Conversation

srinivasreddy commented Mar 2, 2016

Uh oh!

rust-highfive commented Mar 2, 2016

Uh oh!

ManishearthMar 2, 2016

Choose a reason for hiding this comment

Uh oh!

steveklabnikMar 2, 2016

Choose a reason for hiding this comment

Uh oh!

steveklabnik commented Mar 2, 2016

Uh oh!

srinivasreddy commented Mar 2, 2016

Uh oh!

ManishearthMar 2, 2016

Choose a reason for hiding this comment

Uh oh!

srinivasreddy commented Mar 2, 2016

Uh oh!

Manishearth commented Mar 2, 2016

Uh oh!

bors commented Mar 2, 2016

Uh oh!

Manishearth commented Mar 2, 2016

Uh oh!

srinivasreddy commented Mar 3, 2016

Uh oh!

ManishearthMar 3, 2016

Choose a reason for hiding this comment

Uh oh!

srinivasreddyMar 3, 2016

Choose a reason for hiding this comment

Uh oh!

Manishearth commented Mar 3, 2016

Uh oh!

bors commented Mar 3, 2016

Uh oh!

bors commented Mar 3, 2016

Uh oh!

Manishearth commented Mar 3, 2016

Uh oh!

bors commented Mar 3, 2016

Uh oh!

srinivasreddy commented Mar 4, 2016

Uh oh!

Manishearth commented Mar 4, 2016

Uh oh!

Manishearth commented Mar 4, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants