Skip to content

truncate i8-s to i1-s when loading constants - #32032

Merged
bors merged 1 commit into
rust-lang:masterfrom
arielb1:load-const
Mar 4, 2016
Merged

truncate i8-s to i1-s when loading constants#32032
bors merged 1 commit into
rust-lang:masterfrom
arielb1:load-const

Conversation

@arielb1

@arielb1arielb1 commented Mar 3, 2016

Copy link
Copy Markdown
Contributor

Fixes#30891

r? @eddyb

eddyb
eddyb reviewed Mar 3, 2016
View reviewed changes
Comment threadsrc/librustc_trans/trans/consts.rs Outdated

@eddybeddybMar 3, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there something similar in base::load_ty, using LLVMGetInitializer?

@arielb1arielb1Mar 3, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a variant of load_ty that uses the const llvm functions.

@eddybeddybMar 3, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, load_ty already handles this correctly via to_arg_ty.

@eddyb

eddyb commented Mar 3, 2016

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Mar 3, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit cf29344 has been approved by eddyb

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 4, 2016
@Manishearth
Rollup merge ofrust-lang#32032- arielb1:load-const, r=eddyb
714301a
Fixesrust-lang#30891
r? @eddyb
@ManishearthManishearth mentioned this pull request Mar 4, 2016
Closed
@bors

bors commented Mar 4, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit cf29344 with merge c97524b...

bors added a commit that referenced this pull request Mar 4, 2016
@bors
Auto merge of#32032- arielb1:load-const, r=eddyb
c97524b
Fixes#30891
r? @eddyb
@bors

bors commented Mar 4, 2016

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors
bors merged commit cf29344 into rust-lang:masterMar 4, 2016
@arielb1arielb1 added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 4, 2016
@arielb1

arielb1 commented Mar 4, 2016

Copy link
Copy Markdown
ContributorAuthor

nominating for beta since this fixes a regression.

@llogiqllogiq mentioned this pull request Mar 6, 2016
Closed
@nikomatsakisnikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 10, 2016
@alexcrichtonalexcrichton mentioned this pull request Mar 16, 2016
Merged
@brsonbrson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 22, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@eddybeddyb

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@arielb1@eddyb@bors@brson@nikomatsakis