std: Fix tracking issues and clean deprecated APIs by alexcrichton · Pull Request #32112 · rust-lang/rust

alexcrichton · 2016-03-08T00:39:42Z

This PR fixes up a number of discrepancies found with tracking issues (some closed, some needed new ones, etc), and also cleans out all pre-1.8 deprecated APIs. The big beast here was dealing with std::dynamic_lib, and via many applications of a large hammer it's now out of the standard library.

alexcrichton · 2016-03-08T01:31:24Z

r? @aturon

bors · 2016-03-11T16:11:58Z

☔ The latest upstream changes (presumably #32133) made this pull request unmergeable. Please resolve the merge conflicts.

aturon · 2016-03-11T23:58:22Z

r=me, very nice.

alexcrichton · 2016-03-12T00:06:48Z

@bors: r=aturon 2c54926a1cc661e42b00c1cebe7a4ccb643cbf65

bors · 2016-03-12T03:55:49Z

☔ The latest upstream changes (presumably #32200) made this pull request unmergeable. Please resolve the merge conflicts.

Don't want to pollute the source tree!

This isn't exported so it doesn't need a tag.

These are all insta-stable anyway, so just properly tag them.

The referenced issues here were both closed, so hook up a new issue which tracks specifically the prelude traits being unstable.

The listed tracking issue was hooked up to the wrong location by accident.

alexcrichton · 2016-03-12T06:10:25Z

@bors: r=aturon 95812ac

sfackler · 2016-03-12T07:12:21Z

Travis is unhappy: https://travis-ci.org/rust-lang/rust/builds/115483851#L1725

bors · 2016-03-12T08:04:43Z

⌛ Testing commit 95812ac with merge 08d32fa...

Manishearth · 2016-03-12T08:10:02Z

../src/libstd\sys/unix\net.rs:24:1: 24:31 warning: `pub extern crate` does not work as expected and should not be used. Likely to become an error. Prefer `extern crate` and `pub use`.
../src/libstd\sys/unix\net.rs:24 pub extern crate libc as netc;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/libstd\sys/windows\handle.rs:138:48: 138:56 error: unresolved name `c::FALSE` [E0425]
../src/libstd\sys/windows\handle.rs:138 let wait = if wait {c::TRUE} else {c::FALSE};
^~~~~~~~
../src/libstd\sys/windows\handle.rs:138:48: 138:56 help: run `rustc --explain E0425` to see a detailed explanation
../src/libstd\sys/windows\pipe.rs:143:57: 143:65 error: unresolved name `c::FALSE` [E0425]
../src/libstd\sys/windows\pipe.rs:143 c::WaitForMultipleObjects(2, objs.as_ptr(), c::FALSE, c::INFINITE)
^~~~~~~~
../src/libstd\sys/windows\pipe.rs:143:57: 143:65 help: run `rustc --explain E0425` to see a detailed explanation

bors · 2016-03-12T08:11:19Z

⛄ The build was interrupted to prioritize another pull request.

bors · 2016-03-12T08:20:54Z

⌛ Testing commit 95812ac with merge 51644a9...

bors · 2016-03-12T08:25:23Z

💔 Test failed - auto-win-msvc-32-opt

alexcrichton · 2016-03-12T18:00:41Z

@bors: r=aturon c2c5092

bors · 2016-03-12T19:54:14Z

⌛ Testing commit c2c5092 with merge b5241a8...

bors · 2016-03-12T20:26:29Z

💔 Test failed - auto-linux-64-x-android-t

Removes all unstable and deprecated APIs prior to the 1.8 release. All APIs that are deprecated in the 1.8 release are sticking around for the rest of this cycle. Some notable changes are: * The `dynamic_lib` module was moved into `rustc_back` as the compiler still relies on a few bits and pieces. * The `DebugTuple` formatter now special-cases an empty struct name with only one field to append a trailing comma.

alexcrichton · 2016-03-12T20:31:31Z

@bors: r=aturon b53764c

bors · 2016-03-12T21:21:07Z

⌛ Testing commit b53764c with merge a2c56de...

std: Fix tracking issues and clean deprecated APIs This PR fixes up a number of discrepancies found with tracking issues (some closed, some needed new ones, etc), and also cleans out all pre-1.8 deprecated APIs. The big beast here was dealing with `std::dynamic_lib`, and via many applications of a large hammer it's now out of the standard library.

bors · 2016-03-13T00:18:32Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

alexcrichton assigned aturon Mar 8, 2016

alexcrichton force-pushed the fix-issues branch 2 times, most recently from 138fbf4 to d481d39Compare March 8, 2016 23:57

alexcrichton force-pushed the fix-issues branch 2 times, most recently from c802813 to d80fb96Compare March 11, 2016 23:54

alexcrichton force-pushed the fix-issues branch from d80fb96 to 2c54926Compare March 12, 2016 00:06

alexcrichton added 6 commits March 11, 2016 22:09

alloc: Add unstable issue for FnBox APIs
3dd8b3e

test: Move some test outputs into $(TMPDIR)
9a623f3
Don't want to pollute the source tree!

std: Remove unstable from ReentrantMutex
1c440bd
This isn't exported so it doesn't need a tag.

core: Mark Wrapping impls as stable
a38bf6e
These are all insta-stable anyway, so just properly tag them.

core: Make a new tracking issue for prelude traits
aed7dda
The referenced issues here were both closed, so hook up a new issue which tracks specifically the prelude traits being unstable.

std: Add a tracking issue for Peekable::is_empty
083db64
The listed tracking issue was hooked up to the wrong location by accident.

alexcrichton force-pushed the fix-issues branch from 2c54926 to 95812acCompare March 12, 2016 06:10

Manishearth mentioned this pull request Mar 12, 2016
Rollup of 8 pull requests #32209
Closed

alexcrichton force-pushed the fix-issues branch from 95812ac to c2c5092Compare March 12, 2016 18:00

alexcrichton force-pushed the fix-issues branch from c2c5092 to b53764cCompare March 12, 2016 20:31

bors merged commit b53764c into rust-lang:masterMar 13, 2016

This was referenced Mar 13, 2016
WIP: Implement stable symbol-name generation algorithm. #31539
Closed
Call str::to_owned in String::from and uninline it #32182
Merged
Rollup of 9 pull requests #32192
Closed
[WIP] Implement RFC 1560. #32213
Closed

jfager mentioned this pull request Mar 25, 2016
Tracking issue for DNS in std::net #27705
Closed

alexcrichton deleted the fix-issues branch March 27, 2016 17:49

Uh oh!

Uh oh!

Conversation

alexcrichton commented Mar 8, 2016

Uh oh!

alexcrichton commented Mar 8, 2016

Uh oh!

bors commented Mar 11, 2016

Uh oh!

aturon commented Mar 11, 2016

Uh oh!

alexcrichton commented Mar 12, 2016

Uh oh!

bors commented Mar 12, 2016

Uh oh!

alexcrichton commented Mar 12, 2016

Uh oh!

sfackler commented Mar 12, 2016

Uh oh!

bors commented Mar 12, 2016

Uh oh!

Manishearth commented Mar 12, 2016

Uh oh!

bors commented Mar 12, 2016

Uh oh!

bors commented Mar 12, 2016

Uh oh!

bors commented Mar 12, 2016

Uh oh!

alexcrichton commented Mar 12, 2016

Uh oh!

bors commented Mar 12, 2016

Uh oh!

bors commented Mar 12, 2016

Uh oh!

alexcrichton commented Mar 12, 2016

Uh oh!

bors commented Mar 12, 2016

Uh oh!

bors commented Mar 13, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants