Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #32123
Closed
steveklabnik wants to merge 14 commits into
Closed
Conversation
steveklabnik
commented
Mar 8, 2016
Contributor
- Successful merges: Clarify the semantics of enum discriminants #31772, Prefer 'associated function' over 'static method' in msg. #31830, Fix typos - mismatching parentheses in comments #32084, Update syntax index with OpAssign traits #32092, Clarify documentation for string slicing (Index impls) #32099, Fixed link in ownership documentation #32103, Update a spelling inconsistency #32115
- Failed merges:
TRPL seems to refer to 'static functions' as 'associated functions'. This terminology should be used consistently.
Changed "[vector]" to a link to the vector documentation.
- Mention the sugared syntax for the implementations, since it's not apparent from the docs that `Index<Range<usize>>` corresponds to `&self[a..b]`. - Be specific in that start <= end and end <= len
L26: "zero cost" -> "zero-cost"
Clarify the semantics of enum discriminants cf. https://doc.rust-lang.org/error-index.html#E0082 > The default type for enum discriminants is isize, but it can be adjusted by adding the repr attribute to the enum declaration. It would be great if anyone could check my English.
Prefer 'associated function' over 'static method' in msg. TRPL seems to refer to 'static functions' as 'associated functions'. This terminology should be used consistently.
…crichton Fix typos - mismatching parentheses in comments Fixes mismatching parentheses in the comments of precision example. r? @steveklabnik
…bnik Update syntax index with OpAssign traits book: Update syntax index with OpAssign traits The traits are stable from Rust 1.8.
…chton Clarify documentation for string slicing (Index impls) Clarify documentation for string slicing (Index impls) - Mention the sugared syntax for the implementations, since it's not apparent from the docs that `Index<Range<usize>>` corresponds to `&self[a..b]`. - Be specific in that start <= end and end <= len This is just one fix in response to rust-lang#32057
Fixed link in ownership documentation Changed "[vector]" to a link to the vector documentation.
Update a spelling inconsistency L26: "zero cost" -> "zero-cost"
steveklabnik
commented
Mar 8, 2016
ContributorAuthor
@bors: r+ p=1 |
bors
commented
Mar 8, 2016
Collaborator
📌 Commit c1af8c0 has been approved by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.