rustdoc: improve crate-local inlining

[mitaa]

fixes#28537

r? @alexcrichton

[mitaa]

I'm not quite sure why this is necessary. (rustdoc/viewpath-self.rs is caught in an infinite loop otherwise)

[alexcrichton]

Thanks @mitaa! I wonder if we might be able to get away from dealing with the passes for now? Is there a use case where rustdoc is actually being called with various passes and this isn't working?

I tend to view the passes in rustdoc as kinda a half-baked feature which wasn't ever really ready for prime time :(

[mitaa]

I've backed that commit out for now. The only thing rustdoc is doing "wrong" is overzealous inlining when it isn't required.

It is definitely unfortunate that some passes have to currently to leak out like that such that various points in rustdoc need to have knowledge about them hardcoded in.
That may be better addressed (another time..) by extending the pass system somehow with various hooks into the required stages in rustdoc? IOW by rounding out the pass feature out.

[alexcrichton]

@bors: r+ 7c98399

Thanks! Yeah we can try to round out the pass feature later perhaps.

[bors]

⌛ Testing commit 7c98399 with merge beb444e...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt