Uh oh!
There was an error while loading. Please reload this page.
mk: Add configure option for disabling codegen tests - #32168
Conversation
alexcrichton
commented
Mar 10, 2016
cc @wycats @LeoUnglaub |
alexcrichton
commented
Mar 10, 2016
r? @brson |
alexcrichton
commented
Mar 10, 2016
Also note that this is only "lightly tested" currently |
leo-unglaub
commented
Mar 11, 2016
I looked over the code and for me it looks good. But even with that patch i was unable of building it myself. But that is something for another ticket. This one looks good for me. Bit thanks for taking on this issue! You are the best! |
bors
commented
Mar 18, 2016
☔ The latest upstream changes (presumably #32080) made this pull request unmergeable. Please resolve the merge conflicts. |
c0954a7 to
295a70fCompareaturon
commented
Apr 1, 2016
@bors: r+ |
bors
commented
Apr 1, 2016
📌 Commit 295a70f has been approved by |
bors
commented
Apr 2, 2016
⌛ Testing commit 295a70f with merge 660fa89... |
bors
commented
Apr 2, 2016
💔 Test failed - auto-win-msvc-64-opt-rustbuild |
alexcrichton
commented
Apr 3, 2016
@bors: retry On Fri, Apr 1, 2016 at 8:38 PM, bors notifications@github.com wrote:
|
bors
commented
Apr 3, 2016
⌛ Testing commit 295a70f with merge 0918f82... |
bors
commented
Apr 3, 2016
💔 Test failed - auto-linux-64-nopt-t |
Our `codegen` test suite requires the LLVM `FileCheck` utility but unfortunately this isn't always available in all custom LLVM roots (e.g. those specified via `--llvm-root`). This commit adds a `./configure` option called `--disable-codegen-tests` which will manually disable running these tests. In the case that this option is passed we can forgo the need for the `FileCheck` executable. Note that we still require `FileCheck` by default as we will attempt to run these tests. Closesrust-lang#28667
alexcrichton
commented
Apr 3, 2016
bors
commented
Apr 3, 2016
mk: Add configure option for disabling codegen tests Our `codegen` test suite requires the LLVM `FileCheck` utility but unfortunately this isn't always available in all custom LLVM roots (e.g. those specified via `--llvm-root`). This commit adds a `./configure` option called `--disable-codegen-tests` which will manually disable running these tests. In the case that this option is passed we can forgo the need for the `FileCheck` executable. Note that we still require `FileCheck` by default as we will attempt to run these tests. Closes#28667
Our
codegentest suite requires the LLVMFileCheckutility but unfortunatelythis isn't always available in all custom LLVM roots (e.g. those specified via
--llvm-root). This commit adds a./configureoption called--disable-codegen-testswhich will manually disable running these tests. Inthe case that this option is passed we can forgo the need for the
FileCheckexecutable. Note that we still require
FileCheckby default as we will attemptto run these tests.
Closes#28667