Skip to content

first round of removal of integer suffixes - #32177

Merged
bors merged 2 commits into
rust-lang:masterfrom
srinivasreddy:remove_integer_suffixes
Mar 28, 2016
Merged

first round of removal of integer suffixes#32177
bors merged 2 commits into
rust-lang:masterfrom
srinivasreddy:remove_integer_suffixes

Conversation

@srinivasreddy

@srinivasreddysrinivasreddy commented Mar 10, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@steveklabnik

steveklabnik commented Mar 10, 2016

Copy link
Copy Markdown
Contributor

🤘

@alexcrichton

alexcrichton commented Mar 10, 2016

Copy link
Copy Markdown
Member

Looks like some tests are failing, but otherwise

r? @steveklabnik

@srinivasreddysrinivasreddy changed the title [WIP] - first round of removal of integer suffixes first round of removal of integer suffixesMar 10, 2016
oli-obk
oli-obk reviewed Mar 11, 2016
View reviewed changes
Comment threadsrc/libcollectionstest/slice.rs Outdated

@oli-obkoli-obkMar 11, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't this change from 1kb to 4kb? because it's inferred to i32 now

@steveklabniksteveklabnikMar 11, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this one should stay.

@srinivasreddysrinivasreddy mentioned this pull request Mar 11, 2016
Closed
@srinivasreddy

srinivasreddy commented Mar 20, 2016

Copy link
Copy Markdown
ContributorAuthor

ping @steveklabnik . Please include this and roll up again :)

@steveklabnik

steveklabnik commented Mar 28, 2016

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

@bors

bors commented Mar 28, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 91a42be has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Mar 28, 2016
@steveklabnik
Rollup merge ofrust-lang#32177- srinivasreddy:remove_integer_suffix…
f2c6b51
…es, r=steveklabnik
first round of removal of integer suffixes
@steveklabniksteveklabnik mentioned this pull request Mar 28, 2016
Merged
bors added a commit that referenced this pull request Mar 28, 2016
@bors
Auto merge of#32561- steveklabnik:rollup, r=steveklabnik
221c940
Rollup of 7 pull requests
- Successful merges: #32177, #32235, #32472, #32504, #32507, #32509, #32534
- Failed merges:
@bors
bors merged commit 91a42be into rust-lang:masterMar 28, 2016
@srinivasreddy
srinivasreddy deleted the remove_integer_suffixes branch March 29, 2016 03:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steveklabniksteveklabnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@srinivasreddy@steveklabnik@alexcrichton@bors@oli-obk