Statically link run-pass/command-before-exec so it passes not just whenever we happen to bootstrap perfectly.

[eddyb]

No description provided.

[eddyb]

cc @rust-lang/tools This would probably not be a problem with rustbuild.

[nikomatsakis]

@bors r+

[bors]

📌 Commit 5b7f430 has been approved by nikomatsakis

[alexcrichton]

A fix I also suggested to@pnkfelix would be to just tag this with // no-prefer-dynamic to link it statically.

[Manishearth]

failures:
---- [run-pass] run-pass/command-before-exec.rs stdout ----
error: test run failed!
status: exit code: 101
command: i686-apple-darwin/test/run-pass/command-before-exec.stage2-i686-apple-darwin stdout:
------------------------------------------
------------------------------------------
stderr:
------------------------------------------
thread '<main>' panicked at 'assertion failed: output.status.success()', /Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/src/test/run-pass/command-before-exec.rs:64
note: Run with `RUST_BACKTRACE=1` for a backtrace.
------------------------------------------
thread '[run-pass] run-pass/command-before-exec.rs' panicked at 'explicit panic', /Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/src/compiletest/runtest.rs:1651
note: Run with `RUST_BACKTRACE=1` for a backtrace.
failures:
[run-pass] run-pass/command-before-exec.rs

[eddyb]

@Manishearth What, the test is broken even at stage2?!

[eddyb]

sigh reproduced locally. Time to use // no-prefer-dynamic.

EDIT: It appears to be the same parallelism nonsense I hit in #32080.
Oh and running make check-stage{1,2}-rpass -j2 breaks horribly. TIL.

EDIT2: Could also be bootstrapping failing to produce the same symbols.

[nikomatsakis]

@bors r+

[bors]

📌 Commit 27217e5 has been approved by nikomatsakis

[arielb1]

@bors r+

[bors]

💡 This pull request was already approved, no need to approve it again.

• There's another pull request that is currently being tested, blocking this pull request: Add tests for #26114 #32010

[bors]

📌 Commit 27217e5 has been approved by arielb1

[eddyb]

@bors p=10000 Apparently this test is preventing other PRs from landing. Amazing how we got there in the first place.

[eddyb]

@bors r+ force

[bors]

💡 This pull request was already approved, no need to approve it again.

• There's another pull request that is currently being tested, blocking this pull request: cleanups and fixes for #[derive] #32139

[bors]

📌 Commit 27217e5 has been approved by eddyb

[bors]

⌛ Testing commit 27217e5 with merge 8788ffc...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt