Skip to content

Fix import resolution bug - #32227

Merged
bors merged 3 commits into
rust-lang:masterfrom
jseyfried:fix_import_resolution_bug
Mar 13, 2016
Merged

Fix import resolution bug#32227
bors merged 3 commits into
rust-lang:masterfrom
jseyfried:fix_import_resolution_bug

Conversation

@jseyfried

@jseyfriedjseyfried commented Mar 13, 2016

Copy link
Copy Markdown
Contributor

This fixes#32222, which was introduced in #31726.

@jseyfried

jseyfried commented Mar 13, 2016

Copy link
Copy Markdown
ContributorAuthor

Whenever decrement_outstanding_references_for caused an indeterminate NameResolution to become a success (by no longer blocking a glob import), the binding was defined in all known glob importers of its containing module.

This use of decrement_outstanding_references_for was incorrect since it would only make the resolution successful temporarily (after which the resolution is reverted to its previous state). It caused a binding to be defined in all known glob importers each time the resolution became temporarily successful, leading to incorrect duplicate errors (and other privacy-related bugs).

@jseyfried

jseyfried commented Mar 13, 2016

Copy link
Copy Markdown
ContributorAuthor

r? @alexcrichton

@alexcrichton

alexcrichton commented Mar 13, 2016

Copy link
Copy Markdown
Member

@bors: r+ d102014

Thanks for the quick fix @jseyfried! Does this affect beta as well do you know? If so this would probably be a good candidate for a backport.

@bors

bors commented Mar 13, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit d102014 with merge d5880ff...

bors added a commit that referenced this pull request Mar 13, 2016
@bors
Auto merge of#32227- jseyfried:fix_import_resolution_bug, r=alexcri…
d5880ff
…chton
Fix import resolution bug
This fixes#32222, which was introduced in #31726.
@bors

bors commented Mar 13, 2016

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors
bors merged commit d102014 into rust-lang:masterMar 13, 2016
@borsbors mentioned this pull request Mar 13, 2016
Closed
@jseyfried

jseyfried commented Mar 14, 2016

Copy link
Copy Markdown
ContributorAuthor

@alexcrichton this doesn't affect beta.

@jseyfried
jseyfried deleted the fix_import_resolution_bug branch March 17, 2016 13:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Very minor changes causing unrelated module to fail to compile in a nonsense fashion

3 participants

@jseyfried@alexcrichton@bors