Uh oh!
There was an error while loading. Please reload this page.
Fix usability problem when browse document locally - #32308
Merged
Conversation
alexcrichton
commented
Mar 17, 2016
Member
eddyb
commented
Mar 19, 2016
Contributor
@bors rollup |
eddyb added a commit
to eddyb/rust
that referenced
this pull request
Mar 19, 2016
Fix usability problem when browse document locally You cannot use `history.replaceState` when you browse locally, it breaks the security policy of Chrome and perhaps other browsers. Closesrust-lang#32307 Thank @crumblingstatue for the help!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You cannot use
history.replaceStatewhen you browse locally, it breaks the security policy of Chrome and perhaps other browsers.Closes#32307
Thank @crumblingstatue for the help!