Uh oh!
There was an error while loading. Please reload this page.
Add doc examples - #32322
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
standard rust style has no space before the :, can you modify this in all the examples?
Also, it's a bit strange to annotate the types here, is there a specific reason?
MemberAuthor
There was a problem hiding this comment.
standard rust style has no space before the :, can you modify this in all the examples?
Indeed, I'll update it in all my changes.
Also, it's a bit strange to annotate the types here, is there a specific reason?
I wanted to make the example as easy to understand as possible. Like this, there is no debate on the type and tkey can focus on what I want to show them.
GuillaumeGomez
commented
Mar 18, 2016
MemberAuthor
Updated. |
steveklabnik
commented
Mar 21, 2016
Contributor
@bors: r+ rollup |
bors
commented
Mar 21, 2016
Collaborator
📌 Commit 3aac461 has been approved by |
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
Mar 21, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#29347
r? @steveklabnik