Uh oh!
There was an error while loading. Please reload this page.
docs: The data-layout field is no longer required in custom targets - #32375
Conversation
rust-highfive
commented
Mar 20, 2016
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jroesch (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
japaric
commented
Mar 20, 2016
Could you change 'data-layout' for 'os'? That one is also a required field. |
The `data-layout` field was made optional in 958d563. The `os` field is always required.
phil-opp
commented
Mar 20, 2016
Done. It seems like the list of required items is complete now. |
japaric
commented
Mar 20, 2016
Yes, thank you! @bors: r+ rollup |
bors
commented
Mar 20, 2016
📌 Commit 9532602 has been approved by |
The
data-layoutfield is no longer required. It was made optional in 958d563.The
osfield is always required.Related to #31367