Skip to content

doc: remove needless bindings - #32440

Merged
bors merged 1 commit into
rust-lang:masterfrom
tshepang:compact
Mar 26, 2016
Merged

doc: remove needless bindings#32440
bors merged 1 commit into
rust-lang:masterfrom
tshepang:compact

Conversation

@tshepang

@tshepangtshepang commented Mar 23, 2016

Copy link
Copy Markdown
Member

The extra syntax is more noise than help in simple examples like this

@rust-highfive

rust-highfive commented Mar 23, 2016

Copy link
Copy Markdown
Contributor

r? @jroesch

(rust_highfive has picked a reviewer for you, use r? to override)

steveklabnik
steveklabnik reviewed Mar 23, 2016
View reviewed changes
Comment threadsrc/librustc_unicode/char.rs Outdated

@steveklabniksteveklabnikMar 23, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing my heart, tisk tisk! 😉

@steveklabnik

steveklabnik commented Mar 23, 2016

Copy link
Copy Markdown
Contributor

So, I think I feel good about this change, but I'm not sure. @GuillaumeGomez , what do you think?

@GuillaumeGomez

GuillaumeGomez commented Mar 23, 2016

Copy link
Copy Markdown
Member

In this case, it's obvious we're working on chars so the binding seems useless for me as well. I'm all for it! :)

@steveklabnik

steveklabnik commented Mar 23, 2016

Copy link
Copy Markdown
Contributor

The heart change is actually breaking; 💖 is a char, but ❤️ isn't.

@eddyb

eddyb commented Mar 23, 2016

Copy link
Copy Markdown
Contributor

@steveklabnik They both are single Unicode codepoints, but @tshepang actually had "\u{2764}\u{fe0f}" - the second codepoint being "Variation Selector 16". It doesn't add the sparkles for me, but some OS with pervasive normalization might cause this on copy/paste.

EDIT: Actually, it's supposed to be "emoji style". Either way, the second codepoint can be safely removed.

@tshepang

tshepang commented Mar 24, 2016

Copy link
Copy Markdown
MemberAuthor

I reverted the weird heart thing

@steveklabnik

steveklabnik commented Mar 24, 2016

Copy link
Copy Markdown
Contributor

travis is happy so i am happy. Thanks @tshepang !

@bors: r+ rollup

@bors

bors commented Mar 24, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 2c48214 has been approved by steveklabnik

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 26, 2016
@Manishearth
Rollup merge ofrust-lang#32440- tshepang:compact, r=steveklabnik
b6b2dbd
doc: remove needless bindings
The extra syntax is more noise than help in simple examples like this
@ManishearthManishearth mentioned this pull request Mar 26, 2016
Closed
bors added a commit that referenced this pull request Mar 26, 2016
@bors
Auto merge of#32495- Manishearth:rollup, r=<try>
49312a4
Rollup of 18 pull requests
- Successful merges: #32131, #32199, #32257, #32325, #32383, #32387, #32432, #32435, #32440, #32447, #32448, #32456, #32468, #32470, #32476, #32478, #32484, #32492
- Failed merges: #32240, #32469, #32482
Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 26, 2016
@Manishearth
Rollup merge ofrust-lang#32440- tshepang:compact, r=steveklabnik
887e927
doc: remove needless bindings
The extra syntax is more noise than help in simple examples like this
@ManishearthManishearth mentioned this pull request Mar 26, 2016
Merged
bors added a commit that referenced this pull request Mar 26, 2016
@bors
Auto merge of#32508- Manishearth:rollup, r=Manishearth
8f34053
Rollup of 6 pull requests
- Successful merges: #32383, #32387, #32440, #32470, #32478, #32492
- Failed merges:
@bors
bors merged commit 2c48214 into rust-lang:masterMar 26, 2016
@tshepang
tshepang deleted the compact branch March 30, 2016 09:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jroeschjroesch

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tshepang@rust-highfive@steveklabnik@GuillaumeGomez@eddyb@bors@jroesch