implements issue #2356

[Vincent-Belliard]

This commit modify the error message when an identifier is not found but it can be found in the class.
The old message was:
issue_2356.rs:22:16: 22:21 error: unresolved name: xyzt
The new message is:
issue_2356.rs:22:16: 22:20 error: unresolved name: xyzt.Did you mean: self.xyzt

I started looking at rust sources yesterday. It's my first commit which modify the sources. I hope I followed all the coding rules.

[catamorphism]

@Vincent-Belliard -- Thanks for the patch! The first thing I'm noticing is that you're using while loops instead of for loops. Generally, in Rust, we use for loops because they're less error-prone (you can't forget to increment the index), so long as you're incrementing the index in a uniform way. Can you rewrite with for and rebase against HEAD of incoming, then submit another patch? Thanks again!

[catamorphism]

By the way, there's a style guide at https://github.com/mozilla/rust/wiki/Note-style-guide but it's still pretty sketchy at the moment.

[Vincent-Belliard]

I use for loops now. I just left the first while because we need to
inspect ribs in reverse order.

I read the few style guides I found but there are not too many things
inside.

On 08/23/2012 09:35 PM, Tim Chevalier wrote:

By the way, there's a style guide at
https://github.com/mozilla/rust/wiki/Note-style-guide but it's still
pretty sketchy at the moment.

—
Reply to this email directly or view it on GitHub
#3252 (comment).

[catamorphism]

@Vincent-Belliard : Looks great for the most part! I made a few comments as line-by-line notes on your two commits. Since there are a few issues to fix, I figured I would let you fix them and submit a new commit -- if it was just a matter of rebasing off HEAD, I would do it myself, but it's a bit more involved. Hopefully my comments are understandable -- if not, just ask (or find me on IRC -- my nick there is tjc).

Sorry this has turned out to be a bit involved, but if you fix the (minor) issues and resubmit a commit -- preferable combining the two commits into a single one -- I'll merge it. Thanks!

[Vincent-Belliard]

I modified the commit to include all you remarks. I rebased it against head of incoming.

Thank you for for taking some of your time to help me beginning with Rust.

[catamorphism]

Merged, thank you!

[catamorphism]

Sorry, forgot one more thing: I'll add it myself in this case, but in general, every commit should come with a regression test that ensures that the change that was made behaves correctly. Occasionally this would be difficult, but usually it's not hard.