Uh oh!
There was an error while loading. Please reload this page.
Remove no longer necessary coercions to fn pointer types. - #32612
Merged
Conversation
rust-highfive
commented
Mar 30, 2016
Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
frewsxcvforce-pushed
the
unnecessary-coercions
branch
2 times, most recently
from
March 30, 2016 13:44
49976aa to
7559a3aComparefrewsxcv
commented
Mar 30, 2016
ContributorAuthor
cc @nikomatsakis (since you were the author of 8fe9e4d) |
Originally added in 8fe9e4d. Everything appears to build fine without the coercions, so they can presumably be removed.
frewsxcvforce-pushed
the
unnecessary-coercions
branch
from
March 30, 2016 13:50
7559a3a to
99501e6Comparealexcrichton
commented
Mar 30, 2016
Member
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Mar 30, 2016
…lexcrichton Remove no longer necessary coercions to fn pointer types. Originally added in 8fe9e4d. Everything appears to build fine without the coercions, so they can presumably be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally added in 8fe9e4d.
Everything appears to build fine without the coercions, so they can
presumably be removed.