Fix LLVM assert when handling bad intrinsic monomorphizations by Amanieu · Pull Request #32649 · rust-lang/rust

Amanieu · 2016-03-31T14:56:35Z

Passing an invalid type to certain intrinsics would trigger an LLVM assert even though the invalid type was caught by the compiler.

r? @eddyb

eddyb · 2016-03-31T14:58:12Z

@bors r+ rollup

bors · 2016-03-31T14:58:13Z

📌 Commit ecc0bd2 has been approved by eddyb

Rollup of 11 pull requests - Successful merges: #32622, #32629, #32640, #32641, #32642, #32645, #32647, #32649, #32652, #32654, #32656 - Failed merges:

Manishearth · 2016-04-06T07:14:28Z

@bors r-; feel free to re-r when the test is fixed

http://buildbot.rust-lang.org/builders/auto-linux-64-opt-mir/builds/181/steps/test/logs/stdio


failures:
---- [compile-fail] compile-fail/bad-intrinsic-monomorphization.rs stdout ----
error: unexpected compiler message: '/buildslave/rust-buildbot/slave/auto-linux-64-opt-mir/build/src/test/compile-fail/bad-intrinsic-monomorphization.rs:26:1: 29:2 error: invalid monomorphization of `cttz` intrinsic: expected basic integer type, found `Foo` [E0511]'
error: unexpected compiler message: '/buildslave/rust-buildbot/slave/auto-linux-64-opt-mir/build/src/test/compile-fail/bad-intrinsic-monomorphization.rs:31:1: 34:2 error: invalid monomorphization of `fadd_fast` intrinsic: expected basic float type, found `Foo` [E0511]'
error: unexpected compiler message: '/buildslave/rust-buildbot/slave/auto-linux-64-opt-mir/build/src/test/compile-fail/bad-intrinsic-monomorphization.rs:36:1: 39:2 error: invalid monomorphization of `simd_add` intrinsic: expected SIMD input type, found non-SIMD `Foo` [E0511]'
error: expected error on line 27 not found: `cttz` intrinsic: expected basic integer type, found `Foo`
error: expected error on line 32 not found: `fadd_fast` intrinsic: expected basic float type, found `Foo`
error: expected error on line 37 not found: `simd_add` intrinsic: expected SIMD input type, found non-SIMD `Foo`
error: 3 unexpected errors found, 3 expected errors not found
status: exit code: 101
command: x86_64-unknown-linux-gnu/stage2/bin/rustc /buildslave/rust-buildbot/slave/auto-linux-64-opt-mir/build/src/test/compile-fail/bad-intrinsic-monomorphization.rs -L x86_64-unknown-linux-gnu/test/compile-fail/ --target=x86_64-unknown-linux-gnu -L x86_64-unknown-linux-gnu/test/compile-fail/bad-intrinsic-monomorphization.stage2-x86_64-unknown-linux-gnu.compile-fail.libaux -C prefer-dynamic -o x86_64-unknown-linux-gnu/test/compile-fail/bad-intrinsic-monomorphization.stage2-x86_64-unknown-linux-gnu --cfg rtopt -Z orbit -C rpath -O -L x86_64-unknown-linux-gnu/rt
stdout:
------------------------------------------
------------------------------------------
stderr:
------------------------------------------
/buildslave/rust-buildbot/slave/auto-linux-64-opt-mir/build/src/test/compile-fail/bad-intrinsic-monomorphization.rs:26:1: 29:2 error: invalid monomorphization of `cttz` intrinsic: expected basic integer type, found `Foo` [E0511]
/buildslave/rust-buildbot/slave/auto-linux-64-opt-mir/build/src/test/compile-fail/bad-intrinsic-monomorphization.rs:26 unsafe fn test_cttz(v: Foo) -> Foo {
/buildslave/rust-buildbot/slave/auto-linux-64-opt-mir/build/src/test/compile-fail/bad-intrinsic-monomorphization.rs:27 intrinsics::cttz(v)
/buildslave/rust-buildbot/slave/auto-linux-64-opt-mir/build/src/test/compile-fail/bad-intrinsic-monomorphization.rs:28 //~^ ERROR `cttz` intrinsic: expected basic integer type, found `Foo`
/buildslave/rust-buildbot/slave/auto-linux-64-opt-mir/build/src/test/compile-fail/bad-intrinsic-monomorphization.rs:29 }
/buildslave/rust-buildbot/slave/auto-linux-64-opt-mir/build/src/test/compile-fail/bad-intrinsic-monomorphization.rs:26:1: 29:2 help: run `rustc --explain E0511` to see a detailed explanation
/buildslave/rust-buildbot/slave/auto-linux-64-opt-mir/build/src/test/compile-fail/bad-intrinsic-monomorphization.rs:31:1: 34:2 error: invalid monomorphization of `fadd_fast` intrinsic: expected basic float type, found `Foo` [E0511]
/buildslave/rust-buildbot/slave/auto-linux-64-opt-mir/build/src/test/compile-fail/bad-intrinsic-monomorphization.rs:31 unsafe fn test_fadd_fast(a: Foo, b: Foo) -> Foo {
/buildslave/rust-buildbot/slave/auto-linux-64-opt-mir/build/src/test/compile-fail/bad-intrinsic-monomorphization.rs:32 intrinsics::fadd_fast(a, b)
/buildslave/rust-buildbot/slave/auto-linux-64-opt-mir/build/src/test/compile-fail/bad-intrinsic-monomorphization.rs:33 //~^ ERROR `fadd_fast` intrinsic: expected basic float type, found `Foo`
/buildslave/rust-buildbot/slave/auto-linux-64-opt-mir/build/src/test/compile-fail/bad-intrinsic-monomorphization.rs:34 }
/buildslave/rust-buildbot/slave/auto-linux-64-opt-mir/build/src/test/compile-fail/bad-intrinsic-monomorphization.rs:31:1: 34:2 help: run `rustc --explain E0511` to see a detailed explanation
/buildslave/rust-buildbot/slave/auto-linux-64-opt-mir/build/src/test/compile-fail/bad-intrinsic-monomorphization.rs:36:1: 39:2 error: invalid monomorphization of `simd_add` intrinsic: expected SIMD input type, found non-SIMD `Foo` [E0511]
/buildslave/rust-buildbot/slave/auto-linux-64-opt-mir/build/src/test/compile-fail/bad-intrinsic-monomorphization.rs:36 unsafe fn test_simd_add(a: Foo, b: Foo) -> Foo {
/buildslave/rust-buildbot/slave/auto-linux-64-opt-mir/build/src/test/compile-fail/bad-intrinsic-monomorphization.rs:37 simd_add(a, b)
/buildslave/rust-buildbot/slave/auto-linux-64-opt-mir/build/src/test/compile-fail/bad-intrinsic-monomorphization.rs:38 //~^ ERROR `simd_add` intrinsic: expected SIMD input type, found non-SIMD `Foo`
/buildslave/rust-buildbot/slave/auto-linux-64-opt-mir/build/src/test/compile-fail/bad-intrinsic-monomorphization.rs:39 }
/buildslave/rust-buildbot/slave/auto-linux-64-opt-mir/build/src/test/compile-fail/bad-intrinsic-monomorphization.rs:36:1: 39:2 help: run `rustc --explain E0511` to see a detailed explanation
error: aborting due to 3 previous errors
------------------------------------------

@eddyb

…assert, r=eddyb Fix LLVM assert when handling bad intrinsic monomorphizations Passing an invalid type to certain intrinsics would trigger an LLVM assert even though the invalid type was caught by the compiler. r? @eddyb

@eddyb

…assert, r=eddyb Fix LLVM assert when handling bad intrinsic monomorphizations Passing an invalid type to certain intrinsics would trigger an LLVM assert even though the invalid type was caught by the compiler. r? @eddyb

Amanieu · 2016-04-06T17:49:52Z

Fixed

eddyb · 2016-04-06T18:00:46Z

@bors r+

bors · 2016-04-06T18:00:47Z

📌 Commit 4d71712 has been approved by eddyb

steveklabnik · 2016-04-06T19:11:47Z

@bors: r-
@bors: rollup-

this apparently failed the rollup #32772 (comment)

Amanieu · 2016-04-06T20:32:13Z

@steveklabnik I've fixed the issue already

alexcrichton · 2016-04-06T20:57:57Z

@bors: r=eddyb 4d71712

bors · 2016-04-07T07:08:15Z

⌛ Testing commit 4d71712 with merge 455fa01...

@eddyb

…ddyb Fix LLVM assert when handling bad intrinsic monomorphizations Passing an invalid type to certain intrinsics would trigger an LLVM assert even though the invalid type was caught by the compiler. r? @eddyb

bors · 2016-04-07T10:07:22Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-64-x-armhf, auto-linux-64-x-armsf, auto-linux-64-x-freebsd, auto-linux-64-x-netbsd, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild

rust-highfive assigned eddyb Mar 31, 2016

Manishearth mentioned this pull request Apr 1, 2016
Rollup of 11 pull requests #32666
Merged

bors added a commit that referenced this pull request Apr 2, 2016
Auto merge of#32666- Manishearth:rollup, r=Manishearth
18172d1
Rollup of 11 pull requests - Successful merges: #32622, #32629, #32640, #32641, #32642, #32645, #32647, #32649, #32652, #32654, #32656 - Failed merges:

Manishearth mentioned this pull request Apr 6, 2016
Rollup of 13 pull requests #32759
Closed

steveklabnik mentioned this pull request Apr 6, 2016
Rollup of 13 pull requests #32771
Closed

steveklabnik mentioned this pull request Apr 6, 2016
Rollup of 12 pull requests #32772
Closed

Fix LLVM assert when handling bad intrinsic monomorphizations
4d71712

Amanieu force-pushed the intrinsic_monomorphization_assert branch from ecc0bd2 to 4d71712Compare April 6, 2016 17:49

bors merged commit 4d71712 into rust-lang:masterApr 7, 2016

Navigation Menu

Uh oh!

Uh oh!

Fix LLVM assert when handling bad intrinsic monomorphizations - #32649

Fix LLVM assert when handling bad intrinsic monomorphizations#32649
bors merged 1 commit into
rust-lang:masterfrom
Amanieu:intrinsic_monomorphization_assert

Amanieu commented Mar 31, 2016

Uh oh!

eddyb commented Mar 31, 2016

Uh oh!

bors commented Mar 31, 2016

Uh oh!

Manishearth commented Apr 6, 2016

Uh oh!

Amanieu commented Apr 6, 2016

Uh oh!

eddyb commented Apr 6, 2016

Uh oh!

bors commented Apr 6, 2016

Uh oh!

steveklabnik commented Apr 6, 2016

Uh oh!

Amanieu commented Apr 6, 2016

Uh oh!

alexcrichton commented Apr 6, 2016

Uh oh!

bors commented Apr 7, 2016

Uh oh!

bors commented Apr 7, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

Amanieu commented Mar 31, 2016

Uh oh!

eddyb commented Mar 31, 2016

Uh oh!

bors commented Mar 31, 2016

Uh oh!

Manishearth commented Apr 6, 2016

Uh oh!

Amanieu commented Apr 6, 2016

Uh oh!

eddyb commented Apr 6, 2016

Uh oh!

bors commented Apr 6, 2016

Uh oh!

steveklabnik commented Apr 6, 2016

Uh oh!

Amanieu commented Apr 6, 2016

Uh oh!

alexcrichton commented Apr 6, 2016

Uh oh!

bors commented Apr 7, 2016

Uh oh!

bors commented Apr 7, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants