Uh oh!
There was an error while loading. Please reload this page.
Drop the default buffer size to 8K - #32695
Merged
Merged
Conversation
rust-highfive
commented
Apr 3, 2016
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
sfackler
commented
Apr 3, 2016
MemberAuthor
Should probably be discussed at libs triage. |
The 64k capacity was picked by me a couple of years ago in the initial implementation of buffered IO adaptors: https://github.com/rust-lang/rust/pull/9091/files#diff-b131eeef531ad098b32f49695a031008R62. 64K was picked for symmetry with libuv, which we no longer use. 64K is *way* larger than the default size of any other language that I can find. C, C++, and Java default to 8K, and Go defaults to 4K. There have been a variety of issues filed relating to this such as rust-lang#31885. Closesrust-lang#31885
alexcrichton
commented
Apr 3, 2016
Member
👍 from me |
sfackler
commented
Apr 7, 2016
MemberAuthor
@bors r=alexcrichton cc @rust-lang/libs |
bors
commented
Apr 7, 2016
Collaborator
📌 Commit 8128817 has been approved by |
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Apr 8, 2016
…ichton The 64k capacity was picked by me a couple of years ago in the initial implementation of buffered IO adaptors: https://github.com/rust-lang/rust/pull/9091/files#diff-b131eeef531ad098b32f49695a031008R62. 64K was picked for symmetry with libuv, which we no longer use. 64K is *way* larger than the default size of any other language that I can find. C, C++, and Java default to 8K, and Go defaults to 4K. There have been a variety of issues filed relating to this such as rust-lang#31885. Closesrust-lang#31885
bors
commented
Apr 8, 2016
Collaborator
bors added a commit
that referenced
this pull request
Apr 8, 2016
Drop the default buffer size to 8K The 64k capacity was picked by me a couple of years ago in the initial implementation of buffered IO adaptors: https://github.com/rust-lang/rust/pull/9091/files#diff-b131eeef531ad098b32f49695a031008R62. 64K was picked for symmetry with libuv, which we no longer use. 64K is *way* larger than the default size of any other language that I can find. C, C++, and Java default to 8K, and Go defaults to 4K. There have been a variety of issues filed relating to this such as #31885. Closes#31885
bors
commented
Apr 8, 2016
Collaborator
Havvy
commented
Apr 12, 2016
Contributor
Why isn't this considered a breaking change? |
bluss
commented
Apr 12, 2016
Contributor
What kind of program would it break? I'm curious. |
Havvy
commented
Apr 13, 2016
Contributor
I'm not quite sure. Which is why I asked. |
sfackler
commented
Apr 13, 2016
MemberAuthor
We have never documented the default buffer size, so basically https://xkcd.com/1172/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 64k capacity was picked by me a couple of years ago in the initial
implementation of buffered IO adaptors:
https://github.com/rust-lang/rust/pull/9091/files#diff-b131eeef531ad098b32f49695a031008R62.
64K was picked for symmetry with libuv, which we no longer use.
64K is way larger than the default size of any other language that I
can find. C, C++, and Java default to 8K, and Go defaults to 4K. There
have been a variety of issues filed relating to this such as #31885.
Closes#31885