librustc_llvm: encapsulate "as" cast from/to a bool

[nodakai]

When the trueness is defined as "!= 0" rather than "== 1", it's error prone to write such a comparison for each occurrence.

[rust-highfive]

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

[alexcrichton]

Stylistically we tend to not have spaces after the ! operator

[alexcrichton]

This seems like it may be a difficult convention to follow as it's easier to just call the function directly and not call an extra function to wrap the result. How do we ensure that we avoid adding more as casts in the future?

[nodakai]

@alexcrichton True, when the underlying APIs themselves have a confusing interface, I can only hope someone modifying this potion of code notices the Bool type has its wrapper functions which are defined 5 lines below it.

[alexcrichton]

I guess my point is that I don't think this is worth it unless we have a deeper change. We're not currently in the mindset of avoiding as as much as possible, so any new calls to LLVM apis will continue to cast bools. Essentially it's easier to use as than it is to use the functions you've added, so the ergonomics are going the wrong way.

[bors]

☔ The latest upstream changes (presumably #31709) made this pull request unmergeable. Please resolve the merge conflicts.

[nagisa]

Should this be closed?

[nodakai]

No.

野田 開 nodakai@gmail.com

2016-05-04 1:19 GMT+08:00 Simonas Kazlauskas notifications@github.com:

Should this be closed?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#32700 (comment)

[alexcrichton]

Closing due to inactivity, but feel free to reopen with a rebase!