Skip to content

impl Default for CondVar, Mutex and RwLock - #32807

Closed
llogiq wants to merge 1 commit into
rust-lang:masterfrom
llogiq:fix-31865
Closed

impl Default for CondVar, Mutex and RwLock#32807
llogiq wants to merge 1 commit into
rust-lang:masterfrom
llogiq:fix-31865

Conversation

@llogiq

Copy link
Copy Markdown
Contributor

this fixes issue #31865

Note: The impls are unstable for now.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@brson

brson commented Apr 7, 2016

Copy link
Copy Markdown
Contributor

Looks related to #32785

@brsonbrson added the T-libs-api [DEPRECATED; DO NOT USE] label Apr 7, 2016
@llogiq

Copy link
Copy Markdown
ContributorAuthor

It is related. And #32785 goes even further than this.

@durka

durka commented Apr 8, 2016

Copy link
Copy Markdown
Contributor

Note: The impls are unstable for now.

That doesn't work for trait impls, right?

@retep998

Copy link
Copy Markdown
Contributor

@durka trait impls are insta-stable. Marking them unstable doesn't really work.

@llogiq

Copy link
Copy Markdown
ContributorAuthor

OK then. I'll remove the unstable attrs if there is still interest.

@alexcrichton

Copy link
Copy Markdown
Member

Thanks for the PR @llogiq! I believe these are all covered by #32785, so I'm going to close in favor of that.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@llogiq@rust-highfive@brson@durka@retep998@alexcrichton